Some make check results

Some make check results

[Jakub Jelinek]

Hi!

I succeeded with i386, i686 (2x - --enable-kernel=2.2.5 and --enable-kernel=2.4.1),
alpha, alphaev6, ia64 builds.
bug-regex12 failed everywhere (expected), likewise bug-erange (DNS
is not set up in our buildroots, I think something like
attached patch would be good) everywhere, string/stratcliff failed
on alpha/alphaev6/ia64 and tst-timer on ia64/i686 (both builds).
This was automated build, so to look up further details or debug it
I need to build again.

2002-09-29  Jakub Jelinek  <jakub@redhat.com>

	* nss/bug-erange.c (main): Don't fail if /etc/resolv.conf doesn't
	exist.

--- libc/nss/bug-erange.c.jj	2002-09-12 03:44:18.000000000 +0200
+++ libc/nss/bug-erange.c	2002-09-29 15:54:16.000000000 +0200
@@ -6,6 +6,7 @@
 #include <string.h>
 #include <stdio.h>
 #include <stdlib.h>
+#include <unistd.h>
 
 int
 main (void)
@@ -35,6 +36,11 @@ main (void)
   if (res != 0 || hp == NULL)
     {
       printf ("gethostbyname_r failed: %s (errno: %m)\n", strerror (res));
+      if (access ("/etc/resolv.conf", R_OK))
+	{
+	  puts ("DNS probably not set up");
+	  return 0;
+	}
       return 1;
     }
 


	Jakub

Re: Some make check results

[Ulrich Drepper]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jakub Jelinek wrote:
> likewise bug-erange (DNS
> is not set up in our buildroots, I think something like
> attached patch would be good) everywhere,

I have put in your patch but I've also moved bug-erange from tests to
xtests.  This goal was creates for just this purpose, tests which cannot
generally be run but are still useful.


> string/stratcliff failed on alpha/alphaev6/ia64

I've asked rth to review the strncpy patch...


> and tst-timer on ia64/i686 (both builds).

Don't know what that is.  Works for me.

- -- 
- --------------.                        ,-.            444 Castro Street
Ulrich Drepper \    ,-----------------'   \ Mountain View, CA 94041 USA
Red Hat         `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQE9l0SV2ijCOnn/RHQRAqTrAKCWUKM+Fk9GTk6ZCuWP2GCjst0PeQCdGPtH
Wzbz9mJA54ONxMmJiz3sjKo=
=c/gX
-----END PGP SIGNATURE-----

[PATCH] Fix tst-timer (was Re: Some make check results)

[Jakub Jelinek]

On Sun, Sep 29, 2002 at 11:21:09AM -0700, Ulrich Drepper wrote:
> I have put in your patch but I've also moved bug-erange from tests to
> xtests.  This goal was creates for just this purpose, tests which cannot
> generally be run but are still useful.

Thanks.

> > string/stratcliff failed on alpha/alphaev6/ia64
> 
> I've asked rth to review the strncpy patch...

That's alpha.
On IA-64 the following segfaults:
#include <sys/mman.h>
#include <string.h>
#include <stdlib.h>

char buf[128] __attribute__((aligned(128)));

int main (void)
{
  int i;
  char *p = mmap (NULL, 65536, PROT_READ, MAP_PRIVATE | MAP_ANON, -1, 0);
  if (p == NULL) abort ();
  memset (p + 65536 - 26, 'T', 26);
  strncpy (buf, p + 65536 - 26, 25);
}

Will debug it.

> > and tst-timer on ia64/i686 (both builds).
> 
> Don't know what that is.  Works for me.

tst-timer fails on sparc build too actually (well, there
it run for 3 hours until I killed that test, with exception of bug-regex12
all other tests succeeded).
On i686 and ia64 the reason is random value in sigev_notify_attributes.
It may well be 0 for you and you don't see the crash, for me it died on:
        newtimer->attr = *(pthread_attr_t *) evp->sigev_notify_attributes;
because evp->sigev_notify_attributes was garbage.
Will need to check sparc if that is the same reason or something else.

2002-09-29  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/pthread/tst-timer.c (main): Clear
	sigev2.sigev_notify_attributes.

--- linuxthreads/sysdeps/pthread/tst-timer.c.jj	2002-09-28 16:37:10.000000000 -0400
+++ linuxthreads/sysdeps/pthread/tst-timer.c	2002-09-29 18:30:42.000000000 -0400
@@ -76,6 +76,7 @@ main (void)
 
   sigev2.sigev_notify = SIGEV_THREAD;
   sigev2.sigev_notify_function = notify_func;
+  sigev2.sigev_notify_attributes = NULL;
 
   setvbuf (stdout, 0, _IOLBF, 0);
 

	Jakub