public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Fix get_proc_path
@ 2003-04-03 11:02 Jakub Jelinek
  2003-04-03 18:48 ` Ulrich Drepper
  0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2003-04-03 11:02 UTC (permalink / raw)
  To: Ulrich Drepper, Roland McGrath; +Cc: Glibc hackers

Hi!

atomic_compare_and_exchange_bool_acq returns non-zero if it failed to
exchange. This fixes getconf _NPROCESSORS_ONLN on my box.

2003-04-03  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/unix/sysv/linux/getsysstats.c (get_proc_path): Reverse test
	for atomic_compare_and_exchange_bool_acq failure.

--- libc/sysdeps/unix/sysv/linux/getsysstats.c.jj	2003-03-21 05:17:37.000000000 -0500
+++ libc/sysdeps/unix/sysv/linux/getsysstats.c	2003-04-03 05:31:09.000000000 -0500
@@ -85,7 +85,7 @@ get_proc_path (char *buffer, size_t bufs
 
   /* Now store the copied value.  But do it atomically.  */
   assert (sizeof (long int) == sizeof (void *__unbounded));
-  if (! atomic_compare_and_exchange_bool_acq (&mount_proc, copy_result, NULL))
+  if (atomic_compare_and_exchange_bool_acq (&mount_proc, copy_result, NULL))
     /* Replacing the value failed.  This means another thread was
        faster and we don't need the copy anymore.  */
     free (copy_result);

	Jakub

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix get_proc_path
  2003-04-03 11:02 [PATCH] Fix get_proc_path Jakub Jelinek
@ 2003-04-03 18:48 ` Ulrich Drepper
  0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2003-04-03 18:48 UTC (permalink / raw)
  To: Jakub Jelinek; +Cc: Roland McGrath, Glibc hackers

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jakub Jelinek wrote:

> atomic_compare_and_exchange_bool_acq returns non-zero if it failed to
> exchange. This fixes getconf _NPROCESSORS_ONLN on my box.

Applied.  Thanks,

- -- 
- --------------.                        ,-.            444 Castro Street
Ulrich Drepper \    ,-----------------'   \ Mountain View, CA 94041 USA
Red Hat         `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+jIH+2ijCOnn/RHQRAlpjAJ9bGbNMX4g6Fakt1QsanGuCk7c0hACfbPlA
F6uqyozhNxfE7e5DLrEe3hk=
=wkbC
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-04-03 18:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-04-03 11:02 [PATCH] Fix get_proc_path Jakub Jelinek
2003-04-03 18:48 ` Ulrich Drepper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).