* Suspect expression in elf/dl-close.c
@ 2003-04-26 18:47 Andreas Schwab
2003-04-26 20:13 ` Ulrich Drepper
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Schwab @ 2003-04-26 18:47 UTC (permalink / raw)
To: libc-hacker
The following line in elf/dl-close.c looks wrong:
while (idx - disp > disp == 0 ? 1 + GL(dl_tls_static_nelem) : 0)
I think it should rather be this:
while (idx - disp > (disp == 0 ? 1 + GL(dl_tls_static_nelem) : 0))
Andreas.
2003-04-26 Andreas Schwab <schwab@suse.de>
* elf/dl-close.c (remove_slotinfo): Fix missing parens.
--- elf/dl-close.c.~1.96.~ 2003-04-25 14:15:34.000000000 +0200
+++ elf/dl-close.c 2003-04-26 20:14:45.000000000 +0200
@@ -80,7 +80,7 @@ remove_slotinfo (size_t idx, struct dtv_
return true;
}
- while (idx - disp > disp == 0 ? 1 + GL(dl_tls_static_nelem) : 0)
+ while (idx - disp > (disp == 0 ? 1 + GL(dl_tls_static_nelem) : 0))
{
--idx;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Suspect expression in elf/dl-close.c
2003-04-26 18:47 Suspect expression in elf/dl-close.c Andreas Schwab
@ 2003-04-26 20:13 ` Ulrich Drepper
0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2003-04-26 20:13 UTC (permalink / raw)
To: Andreas Schwab; +Cc: libc-hacker
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Andreas Schwab wrote:
> The following line in elf/dl-close.c looks wrong:
>
> while (idx - disp > disp == 0 ? 1 + GL(dl_tls_static_nelem) : 0)
Yep. I've applied the patch. Thanks,
- --
- --------------. ,-. 444 Castro Street
Ulrich Drepper \ ,-----------------' \ Mountain View, CA 94041 USA
Red Hat `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE+quhS2ijCOnn/RHQRAphOAJoCk674tvXHlN4GRhHf7IM/Qi/ixgCcDwQW
9YJdAeTvJfrz0Dc0RwRxcYE=
=NEKa
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-04-26 20:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-04-26 18:47 Suspect expression in elf/dl-close.c Andreas Schwab
2003-04-26 20:13 ` Ulrich Drepper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).