From: Ulrich Drepper <drepper@redhat.com>
To: sjmunroe@vnet.ibm.com
Cc: libc-hacker@sources.redhat.com
Subject: Re: [PATCH] PPC64 dl-machine.c change to use GLRO
Date: Mon, 08 Mar 2004 18:39:00 -0000 [thread overview]
Message-ID: <404CBDD1.10306@redhat.com> (raw)
In-Reply-To: <404CAB15.2090806@us.ibm.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Steve Munroe wrote:
>
> - INTUSE (_dl_signal_error) (0, map->l_name, NULL, buffer);
> + GLRO(dl_signal_error) (0, map->l_name, NULL, buffer);
> }
Not correct. You need to use GLRO for that function only outside ld.so.
I've checked in a patch.
Oh, and you again haven't updated the copyright year. In case you use
emacs, use upd-copyr.el (and whitespace.el, I've removed a lot of excess
whitespaces in the ppc files in the last days). If you use something
else which has macro capabilities try to get something like upd-copyr.el
implemented. It checks for accurate copyright years before saving.
- --
⧠Ulrich Drepper ⧠Red Hat, Inc. ⧠444 Castro St ⧠Mountain View, CA â
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
iD8DBQFATL3R2ijCOnn/RHQRAs12AJ0QiLVcTHvEYP7zdSP7fN2YgF8jgACggpRe
nVOLHCxxFwk2WzcsNkp3sbU=
=Uufu
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2004-03-08 18:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-08 17:21 Steve Munroe
2004-03-08 18:39 ` Ulrich Drepper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=404CBDD1.10306@redhat.com \
--to=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=sjmunroe@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).