public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] PPC64 dl-machine.c change to use GLRO
@ 2004-03-08 17:21 Steve Munroe
  2004-03-08 18:39 ` Ulrich Drepper
  0 siblings, 1 reply; 2+ messages in thread
From: Steve Munroe @ 2004-03-08 17:21 UTC (permalink / raw)
  To: libc-hacker, Andreas Jaeger

[-- Attachment #1: Type: text/plain, Size: 92 bytes --]

Found this builf break in this morning cvs. Need to change INTUSE to 
GLRO for dl-machine.c

[-- Attachment #2: ppc64-dl-machine-20040308.txt --]
[-- Type: text/plain, Size: 657 bytes --]

2004-03-08  Steven Munroe  <sjmunroe@us.ibm.com>

	* sysdeps/powerpc/powerpc64/dl-machine.c(_dl_reloc_overflow): Replace
	INTUSE with GLRO.

diff -urN libc23-cvstip-20040308/sysdeps/powerpc/powerpc64/dl-machine.c libc23/sysdeps/powerpc/powerpc64/dl-machine.c
--- libc23-cvstip-20040308/sysdeps/powerpc/powerpc64/dl-machine.c	2003-05-15 23:20:52.000000000 -0500
+++ libc23/sysdeps/powerpc/powerpc64/dl-machine.c	2004-03-08 10:22:46.000000000 -0600
@@ -44,5 +44,5 @@
       t = stpcpy (t, "'");
     }
   t = stpcpy (t, " out of range");
-  INTUSE (_dl_signal_error) (0, map->l_name, NULL, buffer);
+  GLRO(dl_signal_error) (0, map->l_name, NULL, buffer);
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] PPC64 dl-machine.c change to use GLRO
  2004-03-08 17:21 [PATCH] PPC64 dl-machine.c change to use GLRO Steve Munroe
@ 2004-03-08 18:39 ` Ulrich Drepper
  0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2004-03-08 18:39 UTC (permalink / raw)
  To: sjmunroe; +Cc: libc-hacker

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Steve Munroe wrote:
>
> -  INTUSE (_dl_signal_error) (0, map->l_name, NULL, buffer);
> +  GLRO(dl_signal_error) (0, map->l_name, NULL, buffer);
>  }

Not correct.  You need to use GLRO for that function only outside ld.so.
 I've checked in a patch.

Oh, and you again haven't updated the copyright year.  In case you use
emacs, use upd-copyr.el (and whitespace.el, I've removed a lot of excess
whitespaces in the ppc files in the last days).  If you use something
else which has macro capabilities try to get something like upd-copyr.el
implemented.  It checks for accurate copyright years before saving.

- -- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFATL3R2ijCOnn/RHQRAs12AJ0QiLVcTHvEYP7zdSP7fN2YgF8jgACggpRe
nVOLHCxxFwk2WzcsNkp3sbU=
=Uufu
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-03-08 18:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-03-08 17:21 [PATCH] PPC64 dl-machine.c change to use GLRO Steve Munroe
2004-03-08 18:39 ` Ulrich Drepper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).