public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Fix nis_getnames
@ 2006-12-05 19:52 Jakub Jelinek
  2006-12-05 21:27 ` Ulrich Drepper
  0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2006-12-05 19:52 UTC (permalink / raw)
  To: Ulrich Drepper; +Cc: Glibc hackers

Hi!

NIS_PATH is already in UNSECURE_ENVVARS, so ld.so unsetenv's
it during start of suid/sgid programs, so all this __secure_getenv
does is prohibit suid/sgid programs to setenv NIS_PATH to some value
and expect nis_lookup or nis_list with EXPAND_NAME flag set to use it.

2006-12-05  Jakub Jelinek  <jakub@redhat.com>

	* nis/nis_subr.c (nis_getnames): Revert last change.

--- libc/nis/nis_subr.c.jj	2006-10-19 17:26:39.000000000 +0200
+++ libc/nis/nis_subr.c	2006-12-05 20:47:11.000000000 +0100
@@ -178,7 +178,7 @@ nis_getnames (const_nis_name name)
     }
 
   /* Get the search path, where we have to search "name" */
-  path = __secure_getenv ("NIS_PATH");
+  path = getenv ("NIS_PATH");
   if (path == NULL)
     path = strdupa ("$");
   else

	Jakub

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-12-05 21:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-05 19:52 [PATCH] Fix nis_getnames Jakub Jelinek
2006-12-05 21:27 ` Ulrich Drepper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).