Fix warnings in idna.c

Fix warnings in idna.c

[Andreas Jaeger]

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]


I just saw these warnings:

idna.c:445: warning: passing arg 1 of `strlen' from incompatible pointer type
idna.c:445: warning: passing arg 1 of `__strdup' from incompatible pointer type

Ok to commit the appended patch?

Andreas

2004-03-13  Andreas Jaeger  <aj@suse.de>

	* idna.c (idna_to_ascii_4z): Fix warnings.

============================================================
Index: libidn/idna.c
--- libidn/idna.c	13 Mar 2004 06:49:25 -0000	1.2
+++ libidn/idna.c	13 Mar 2004 09:58:24 -0000
@@ -442,7 +442,7 @@ idna_to_ascii_4z (const uint32_t * input
       || (DOTP (input[0]) && input[1] == 0))
     {
 #if defined HAVE_STRDUP || defined _LIBC
-      *output = strdup (input);
+      *output = strdup ((const char *)input);
       return *output == NULL ? IDNA_MALLOC_ERROR : IDNA_SUCCESS;
 #else
       /* Handle implicit zero-length root label. */

-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: Fix warnings in idna.c

[Andreas Schwab]

Andreas Jaeger <aj@suse.de> writes:

> I just saw these warnings:
>
> idna.c:445: warning: passing arg 1 of `strlen' from incompatible pointer type
> idna.c:445: warning: passing arg 1 of `__strdup' from incompatible pointer type
>
> Ok to commit the appended patch?

That looks completely bogus.  How is strcpy/strdup supposed to handle
a uint32_t array?

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."