From: Andreas Jaeger <aj@suse.de>
To: Roland McGrath <roland@redhat.com>
Cc: GNU libc hackers <libc-hacker@sources.redhat.com>
Subject: Re: Testsuite failure in check-localplt
Date: Tue, 09 Oct 2007 05:50:00 -0000 [thread overview]
Message-ID: <m3ir5grg3z.fsf@gromit.moeb> (raw)
In-Reply-To: <20071008211011.C1E9E4D04CC@magilla.localdomain> (sfid-20071009_033107_818411_8F2DB6935CE44DBB) (Roland McGrath's message of "Mon, 8 Oct 2007 14:10:11 -0700 (PDT)")
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
Roland McGrath <roland@redhat.com> writes:
> Look for the relocs in libc.so that refer to those symbols. Probably they
> should be calling __read, which already has libc_hidden_proto. If they are
> in code never reached by ISO C-only, then they could legitimately stick to
> read for aesthetic purposes if one really cared, but then you'd need to add
> libc_hidden_proto for read in include/unistd.h, which we haven't needed yet.
> (If they are in low-level linux-specific code, they might want to be using
> INLINE_SYSCALL anyway.)
Thanks - that helped. It was in eventfd_read and write - and I just
noticed that Uli already committed the obvious fix.
The testsuite passes now for me,
Andreas
--
Andreas Jaeger, Director Platform/openSUSE, aj@suse.de
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
Maxfeldstr. 5, 90409 Nürnberg, Germany
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]
prev parent reply other threads:[~2007-10-09 5:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 19:33 Andreas Jaeger
2007-10-08 21:10 ` Roland McGrath
2007-10-09 5:50 ` Andreas Jaeger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ir5grg3z.fsf@gromit.moeb \
--to=aj@suse.de \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).