Get rid of warning in linuxthreads/spinlock.c

Get rid of warning in linuxthreads/spinlock.c

[Andreas Jaeger]

[-- Attachment #1.1: Type: text/plain, Size: 259 bytes --]


this patch gets rid of:

spinlock.c:33: warning: matching constraint does not allow a register

Ok to commit?
Andreas

2004-01-22  Andreas Jaeger  <aj@suse.de>

	* spinlock.c (__pthread_lock): Fix contraint to avoid warning.
	(__pthread_release): Likewise.


[-- Attachment #1.2: libc-diff --]
[-- Type: text/plain, Size: 802 bytes --]

============================================================
Index: linuxthreads/spinlock.c
--- linuxthreads/spinlock.c	29 Aug 2002 10:32:19 -0000	1.37
+++ linuxthreads/spinlock.c	22 Jan 2004 11:00:37 -0000
@@ -30,7 +30,7 @@ static inline void __pthread_release(int
 {
   WRITE_MEMORY_BARRIER();
   *spinlock = __LT_SPINLOCK_INIT;
-  __asm __volatile ("" : "=m" (*spinlock) : "0" (*spinlock));
+  __asm __volatile ("" : "=m" (*spinlock) : "m" (*spinlock));
 }
 
 
@@ -106,7 +106,7 @@ void internal_function __pthread_lock(st
 #ifdef BUSY_WAIT_NOP
       BUSY_WAIT_NOP;
 #endif
-      __asm __volatile ("" : "=m" (lock->__status) : "0" (lock->__status));
+      __asm __volatile ("" : "=m" (lock->__status) : "m" (lock->__status));
     }
 
     lock->__spinlock += (spin_count - lock->__spinlock) / 8;

[-- Attachment #1.3: Type: text/plain, Size: 192 bytes --]



-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: Get rid of warning in linuxthreads/spinlock.c

[Roland McGrath]

> 
> this patch gets rid of:
> 
> spinlock.c:33: warning: matching constraint does not allow a register
> 
> Ok to commit?

If using the "m" constraint works right in all gcc >= 3.2, then fine.  

> 	* spinlock.c (__pthread_lock): Fix contraint to avoid warning.
					      ^typo

Re: Get rid of warning in linuxthreads/spinlock.c

[Andreas Jaeger]

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

Roland McGrath <roland@redhat.com> writes:

>> 
>> this patch gets rid of:
>> 
>> spinlock.c:33: warning: matching constraint does not allow a register
>> 
>> Ok to commit?
>
> If using the "m" constraint works right in all gcc >= 3.2, then fine.  
>

Yes, it should.  I tested with 3.3 and AFAIK only the warning is
new...

Ok, will commit now,
Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]