public inbox for libc-help@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>,
	Adhemerval Zanella via Libc-help <libc-help@sourceware.org>
Subject: Re: Glibc 2.31 - time64 with 64-bit kernel and 32-bit userland
Date: Mon, 18 Jan 2021 17:31:12 -0300	[thread overview]
Message-ID: <eff7ddd6-74df-3952-af37-fe68141e9fa2@linaro.org> (raw)
In-Reply-To: <87sg6yknoo.fsf@oldenburg.str.redhat.com>



On 18/01/2021 17:14, Florian Weimer wrote:
> * Adhemerval Zanella via Libc-help:
> 
>> This is the expected behavior, running this small example:
>>
>> --
>> #include <time.h>
>>
>> int main (int argc, char *argv[])
>> {
>>   clock_gettime (CLOCK_REALTIME, &((struct timespec) {}));
>>   clock_gettime (CLOCK_BOOTTIME, &((struct timespec) {}));
>>   return 0;
>> }
>> --
>>
>> On a aarch64 kernel without 64-bit compat time_t support (4.12.13),
>> this is the generated syscalls:
>>
>> --
>> clock_gettime64(CLOCK_REALTIME, 0xfffebb58) = -1 ENOSYS (Function not implemented)
>> clock_gettime(CLOCK_REALTIME, {tv_sec=1610997887, tv_nsec=516302599}) = 0
>> clock_gettime(CLOCK_BOOTTIME, {tv_sec=2750059, tv_nsec=271773400}) = 0
>> --
>>
>> The catch here the 64-bit kernel when running 32-bit userland will
>> use compat entrypoints to provide the expected kernel ABI. For kernel 
>> older than v5.1, it means that even if kernel is 64-bit and support 
>> 64-bit time_t, the 32-bit syscall entrypoints won't have 64-bit time_t
>> support.
> 
> Ugh.  Is this for ILP32 support?
> 
> Should we just undefined __NR_clock_gettime64 for 64-bit AArch64?

No, this is armhf default binaries.  This situation is similar to
i686 running on x86_64 kernels.

AArch64 (and any other architecture with default 64-bit time_t)
will build Linux clock_gettime.c as:

int
__clock_gettime64 (clockid_t clock_id, struct __timespec64 *tp)
{
  int r;
# define __NR_clock_gettime64 __NR_clock_gettime
  if (true)
    {
      r = INLINE_VSYSCALL (clock_gettime64, 2, clock_id, tp);
      if (r == 0 || errno != ENOSYS)
        return r;
    }
  return r;
}

  reply	other threads:[~2021-01-18 20:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 17:43 Dr. Todor Dimitrov
2021-01-18 17:51 ` Florian Weimer
2021-01-18 17:57   ` Dr. Todor Dimitrov
2021-01-18 19:31 ` Adhemerval Zanella
2021-01-18 20:10   ` Dr. Todor Dimitrov
2021-01-18 20:14   ` Florian Weimer
2021-01-18 20:31     ` Adhemerval Zanella [this message]
2021-01-18 20:35       ` Florian Weimer
2021-01-18 21:22         ` Adhemerval Zanella
2021-01-19 11:23           ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eff7ddd6-74df-3952-af37-fe68141e9fa2@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=fweimer@redhat.com \
    --cc=libc-help@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).