public inbox for libc-locales@sourceware.org
 help / color / mirror / Atom feed
From: Rafal Luzynski <digitalfreak@lingonborough.com>
To: Marko Myllynen <myllynen@redhat.com>,
	GNU C Library <libc-alpha@sourceware.org>
Cc: "Diego (Egor) Kobylkin" <egor@kobylkin.com>,
	Carlos O'Donell <carlos@redhat.com>,
	Siddhesh Poyarekar <siddhesh@gotplt.org>,
	Mike Fabian <mfabian@redhat.com>,
	"libc-locales@sourceware.org" <libc-locales@sourceware.org>
Subject: Re: [PING^10][PATCH v12] Locales: Cyrillic -> ASCII transliteration [BZ #2872]
Date: Tue, 09 Jul 2019 23:35:00 -0000	[thread overview]
Message-ID: <1703613878.71446.1562715288105@poczta.nazwa.pl> (raw)
In-Reply-To: <5e82c576-fcd2-9d2f-6ea8-c1f55d60d19d@redhat.com>

9.07.2019 08:34 Marko Myllynen <myllynen@redhat.com> wrote:
> 
> Hi,
> 
> It seems that we have consensus so is there anything still left with this?

I think it's helpful to clarify which patches we are talking about.
I think that these TWO patches should be accepted and pushed:

1. [PATCH v12] Locales: Cyrillic -> ASCII transliteration [BZ #2872]
   https://sourceware.org/ml/libc-alpha/2019-03/msg00378.html

It contains Cyrillic to plain ASCII transliteration according to
GOST 7.79-2000 System B standard for the C locales

2. [PATCH v9] Locales: Cyrillic -> ASCII transliteration table [BZ #2872]
   https://sourceware.org/ml/libc-alpha/2018-11/msg00369.html

It contains Cyrillic to Latin extended transliteration according to
ISO 9 standard which is the same as GOST 7.79-2000 System A for almost
all locales, plus a fallback to plain ASCII which is as similar as possible
to GOST 7.70-2000 System A.  However, IMHO one more change is required:
the line converting <U0423><U0301> and <U0443><U0301> (Cyrillic U with
acute, using composition) should be removed, as it was removed in the
v10 of the patch.

Why don't I like v10?  Because it removes the fallback.  The fallback
is not perfect and does not comply with any standard but it has been
already stated that the transliteration does not have to be perfect.

Why these two patches?  Because the v12 contains only Cyrillic to plain
ASCII and only for the C locales while v9 contains Cyrillic to Latin
extended with an attempt to fallback to plain ASCII for many locales
but excluding C.

Additionally, I think we should mention this new feature in NEWS also
stating that this implementation is not perfect and will never be but
further works on the issue are expected in future versions.

> @Egor, do you think the commit message of the latest patch is ok or
> should it be somehow amended by the recent discussions leading to
> consensus or is it ok as-is?

Probably one or two more lines would be nice.

Regards,

Rafal

  reply	other threads:[~2019-07-09 23:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-09  6:35 Marko Myllynen
2019-07-09 23:35 ` Rafal Luzynski [this message]
2019-07-13 10:03   ` Diego (Egor) Kobylkin
2019-07-16  9:45     ` Rafal Luzynski
2019-07-16 10:53       ` Diego (Egor) Kobylkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1703613878.71446.1562715288105@poczta.nazwa.pl \
    --to=digitalfreak@lingonborough.com \
    --cc=carlos@redhat.com \
    --cc=egor@kobylkin.com \
    --cc=libc-alpha@sourceware.org \
    --cc=libc-locales@sourceware.org \
    --cc=mfabian@redhat.com \
    --cc=myllynen@redhat.com \
    --cc=siddhesh@gotplt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).