[Bug localedata/24296] New: Orthographic mistakes in 'day' and 'abday' sections in tt_RU (Tatar) locale

[Bug localedata/24296] New: Orthographic mistakes in 'day' and 'abday' sections in tt_RU (Tatar) locale

[6688000 at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24296

            Bug ID: 24296
           Summary: Orthographic mistakes in 'day' and 'abday' sections in
                    tt_RU (Tatar) locale
           Product: glibc
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: localedata
          Assignee: unassigned at sourceware dot org
          Reporter: 6688000 at gmail dot com
                CC: libc-locales at sourceware dot org
  Target Milestone: ---

Created attachment 11660
  --> https://sourceware.org/bugzilla/attachment.cgi?id=11660&action=edit
A patch file with suggested corrections.

Hello!

tt_RU (Tatar language) locale.

There are three orthographic mistakes in 'day' section:
  'Дышәмбе' should be 'Дүшәмбе'
  'Чәршәәмбе' should be 'Чәршәмбе'
  'Пәнҗешмбе' should be 'Пәнҗешәмбе'
and one typo in 'abday' section:
  'Дыш' should be 'Дүш'

WRONG:
$ LANG=tt_RU locale day
Якшәмбе;Дышәмбе;Сишәмбе;Чәршәәмбе;Пәнҗешмбе;Җомга;Шимбә
$ LANG=tt_RU locale abday
Якш;Дыш;Сиш;Чәрш;Пәнҗ;Җом;Шим

CORRECT:
$ LANG=tt_RU locale day
Якшәмбе;Дүшәмбе;Сишәмбе;Чәршәмбе;Пәнҗешәмбе;Җомга;Шимбә
$ LANG=tt_RU locale abday
Якш;Дүш;Сиш;Чәрш;Пәнҗ;Җом;Шим

I attach a patch file with corresponding corrections.

Correctness of suggested changes can be proved by:
Unicode.org CLDR Charts:
https://www.unicode.org/cldr/charts/34/summary/tt.html
Academic dictionaries of Tatar language:
http://suzlek.antat.ru/

Thank you!

With best wishes,
Mansur

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/24296] Orthographic mistakes in 'day' and 'abday' sections in tt_RU (Tatar) locale

[6688000 at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24296

mansur <6688000 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |6688000 at gmail dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/24296] Orthographic mistakes in 'day' and 'abday' sections in tt_RU (Tatar) locale

[digitalfreak at lingonborough dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24296

Rafal Luzynski <digitalfreak at lingonborough dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |digitalfreak@lingonborough.
                   |                            |com

--- Comment #1 from Rafal Luzynski <digitalfreak at lingonborough dot com> ---
Thank you mansur for the report.  Your patch cannot be easily applied because
it is not formatted by "git format-patch", as a consequence it does not have
the commit comment and your name and email address as an author.  Of course you
may decide to disclaim your authorship and remain anonymous or I may copy your
address and name from this bugzilla report (I guess that "mansur" is a nick,
not a full name).

Of course, CLDR is an authoritative source for us so your request is justified.

I can see some more differences between CLDR and glibc content and I would like
to ask if you want updates.

1. All weekday names (full and abbreviated) start with an uppercase letter in
glibc while with lowercase in CLDR.  Do you think it should be changed?
2. Abbreviated Wednesday (Wed) in CLDR is spelled "чәр", in glibc "Чәрш",
should it be changed?
3. I ignore the trailing dots in CLDR.
4. This may be a separate issue but I think that all month names in tt_RU are
incorrect in glibc.  Can you please review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/24296] Orthographic mistakes in 'day' and 'abday' sections in tt_RU (Tatar) locale

[6688000 at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24296

--- Comment #2 from mansur <6688000 at gmail dot com> ---
Hello, Rafal!

Actually, Mansur is my name and my nickname (for example, in GitHub) is mansayk
:)

Ok, I will make my patch as 'git format-patch'. But first of all we need to
clarify some details. 

And one of them, what is the most convenient way of viewing the strings like 
"<U042F><U043A><U0448><U04D9><U043C><U0431><U0435>" 
in that tt_RU file? Previously I converted it manually character by character,
but I am sure there should be some kind of viewer or something.

PS. I am preparing an answer to your questions.

Thank you!
Mansur

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/24296] Orthographic mistakes in 'day' and 'abday' sections in tt_RU (Tatar) locale

[digitalfreak at lingonborough dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24296

--- Comment #3 from Rafal Luzynski <digitalfreak at lingonborough dot com> ---
"git format-patch" will contain all required information and your patch may be
ready to accept.

(In reply to mansur from comment #2)
> [...] what is the most convenient way of viewing the strings like 
> "<U042F><U043A><U0448><U04D9><U043C><U0431><U0435>" 
> in that tt_RU file?

I use the script filter.py which was posted as part of the patch here:
https://sourceware.org/ml/libc-alpha/2016-04/msg00341.html

It's a work-in-progress and has never been finished but the script is useful.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/24296] Orthographic mistakes in 'day' and 'abday' sections in tt_RU (Tatar) locale

[6688000 at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24296

mansur <6688000 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11660|0                           |1
        is obsolete|                            |

--- Comment #4 from mansur <6688000 at gmail dot com> ---
Created attachment 11682
  --> https://sourceware.org/bugzilla/attachment.cgi?id=11682&action=edit
Patch file with many new corrections and additions.

Hello, Rafal!

1. In Tatar language weekday names do not begin with upper case unless it is
not a beginning of the sentence. In calendars they usually begin with upper
case, or all letters are used in upper case. In the new patch I used lowercase
just like in the most other glibc locale files.

2. Abbreviated ones depend on the allowed length. For example,
Two letter combinations beginning from Monday: Дш, Сш, Чш, Пҗ, Җм, Шм, Як.
Three letter combinations beginning from Monday: Дүш, Сиш, Чәр, Пән, Җом, Шим,
Якш.
There are also combined 3-4 letter combinations beginning from Monday: Дүш,
Сиш, Чәрш, Пәнҗ, Җом, Шим, Якш.
I decided to take the ones with 2 letters because they are used in the most of
calendars.

4. Yes, you were right. There were many mistakes there. I fixed it.

Please take a look at the new patch file.

I will try the filter.py script. Thank you!

With best wishes,
Mansur

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/24296] Orthographic mistakes in 'day' and 'abday' sections in tt_RU (Tatar) locale

[digitalfreak at lingonborough dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24296

--- Comment #5 from Rafal Luzynski <digitalfreak at lingonborough dot com> ---
1. Your patch seems to update many things in the locale file outside the
LC_TIME section.  Are these just changes in spaces?  If yes, please undo them. 
If not, please file a separate bug report.  Even touching month names is beyond
the scope of this bug report.

2. You don't need to (and please don't) provide alt_mon and ab_alt_mon sections
if they are identical to mon and abmon, respectively.

3. Please don't change the abday values to two-letters according to your
personal preference.  Please introduce as few changes as possible and keep the
data synchronized with CLDR.  It is OK to leave uppercase if they were so
before.  It is OK to change to lowercase if CLDR says so.  It is OK to drop the
trailing dots because many locales (including English) do it already.  It is
not OK to introduce your own abbreviations.  If you think that CLDR is wrong
then please file an issue to CLDR (provide scientific language references etc.)
 They are really responsive sometimes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/24296] Orthographic mistakes in 'day' and 'abday' sections in tt_RU (Tatar) locale

[6688000 at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24296

mansur <6688000 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11682|0                           |1
        is obsolete|                            |

--- Comment #6 from mansur <6688000 at gmail dot com> ---
Created attachment 11684
  --> https://sourceware.org/bugzilla/attachment.cgi?id=11684&action=edit
Fixes in day and abday

Hi, Rafal!

Thank you very much for the instructions. 

1. I followed your recommendations and made a new patch according to CLDR data.
I will provide mon and abmon updates in a new bug report.

2. Fixed, thank you for clarification.

3. Done.

Please check the patch file. Thank you!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/24296] Orthographic mistakes in 'day' and 'abday' sections in tt_RU (Tatar) locale

[digitalfreak at lingonborough dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24296

--- Comment #7 from Rafal Luzynski <digitalfreak at lingonborough dot com> ---
Looks good at first sight.  I will provide more feedback on Monday.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/24296] Orthographic mistakes in 'day' and 'abday' sections in tt_RU (Tatar) locale

[cjlhomeaddress at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24296

Chris Leonard <cjlhomeaddress at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cjlhomeaddress at gmail dot com

--- Comment #8 from Chris Leonard <cjlhomeaddress at gmail dot com> ---
(In reply to Rafal Luzynski from comment #3)

> > [...] what is the most convenient way of viewing the strings like 
> > "<U042F><U043A><U0448><U04D9><U043C><U0431><U0435>" 
> > in that tt_RU file?

There is the script that Rafal mentioned, there are also some very workable
Unicode converter websites for really quick and dirty code point to UTF-8
conversion.  Just search for Unicode converter.  Depending on the site, you may
need to drop the >< or U delimiters after copy/paste of text from locale file,
YMMV.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/24296] Orthographic mistakes in 'day' and 'abday' sections in tt_RU (Tatar) locale

[6688000 at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24296

--- Comment #9 from mansur <6688000 at gmail dot com> ---
Hi, Chris!

Thank you for advice. Currently I am using 'ascii2uni' command line tool:
ascii2uni -a A tt_RU

And there is also an opposite tool, named 'uni2ascii':
uni2ascii -a A <file>

I didn't try 'filter.py' yet.

With best wishes,
Mansur

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/24296] Orthographic mistakes in 'day' and 'abday' sections in tt_RU (Tatar) locale

[digitalfreak at lingonborough dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24296

--- Comment #10 from Rafal Luzynski <digitalfreak at lingonborough dot com> ---
Mansur, your recent patch is correct.  This needs a ChangeLog-like list of
changes in the commit message which should be later copied to the ChangeLog
file immediately before pushing.  Also the commit comment should mention the
locale name and this bug number.  But these are details which I can take care
of, if you can't provide them.

However, before accepting this, I have one last question: please take a look at
tt_RU@iqtelif.  Does it require similar changes?  Are you able to provide them
in the same patch?

While at this, please take a look at the bug 21938.  Is there anything you can
help?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/24296] Orthographic mistakes in 'day' and 'abday' sections in tt_RU (Tatar) locale

[6688000 at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24296

mansur <6688000 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11684|0                           |1
        is obsolete|                            |

--- Comment #11 from mansur <6688000 at gmail dot com> ---
Created attachment 11690
  --> https://sourceware.org/bugzilla/attachment.cgi?id=11690&action=edit
Several orthographic mistakes in day and abday sections of tt_RU locale were
fixed.

Hi, Rafal!

ChangeLog:
Several orthographic mistakes in day and abday sections of tt_RU locale were
fixed.

Is this format of changelog message ok?

I added a bug number and a locale name to the patch file.

I took a look in tt_RU@iqtelif locale. As much as I know there are no
officially accepted orthography for that alphabet, so trying to "fix" something
there will be just guessing how it should be in my opinion. And I don't see any
obvious mistakes there in day, abday, mon, abmon sections.

About the bug 21938. I don't know exactly what it depends on, but I suppose
postal_fmt should be the same as in ru_RU locale because both these locales are
mostly used in the same country. Am I right?

Thank you!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/24296] Orthographic mistakes in 'day' and 'abday' sections in tt_RU (Tatar) locale

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24296

--- Comment #12 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  57ada43c905eec7ba28fe60a08b93a52d88e26c1 (commit)
      from  a2e57f89a35e6056c9488428e68c4889e114ef71 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=57ada43c905eec7ba28fe60a08b93a52d88e26c1

commit 57ada43c905eec7ba28fe60a08b93a52d88e26c1
Author: mansayk <6688000@gmail.com>
Date:   Sat Mar 16 11:05:22 2019 +0300

    tt_RU: Fix orthographic mistakes in day and abday sections [BZ #24296]

    This commit fixes some errors and converts all weekday names to lowercase.
    The content is synchronized with CLDR-34 now, but trailing dots are removed
    from abday values in order to maintain consistency with the previous values
    and with many other locales which do the same.

        [BZ #24296]
        * localedata/locales/tt_RU (day): Update from CLDR-34, fix errors.
        (abday): Likewise, but remove the trailing dots.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                |    6 ++++++
 localedata/locales/tt_RU |   28 ++++++++++++++--------------
 2 files changed, 20 insertions(+), 14 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/24296] Orthographic mistakes in 'day' and 'abday' sections in tt_RU (Tatar) locale

[digitalfreak at lingonborough dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24296

Rafal Luzynski <digitalfreak at lingonborough dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.30

--- Comment #13 from Rafal Luzynski <digitalfreak at lingonborough dot com> ---
(In reply to mansur from comment #11)
> [...]
> Is this format of changelog message ok?
> 
> I added a bug number and a locale name to the patch file.

Thank you, it was better.  I've decided not to bother you anymore and corrected
the commit comment and the ChangeLog.  You can see it in comment 12.  Then I
pushed the patch to master.  This bug is fixed now.  Thank you for your
contribution.

> I took a look in tt_RU@iqtelif locale. As much as I know there are no
> officially accepted orthography for that alphabet, so trying to "fix"
> something there will be just guessing how it should be in my opinion. And I
> don't see any obvious mistakes there in day, abday, mon, abmon sections.

Good idea not to change it if you are not sure, if the sources do not exist,
and especially if you can't see any error.

> About the bug 21938. I don't know exactly what it depends on, but I suppose
> postal_fmt should be the same as in ru_RU locale because both these locales
> are mostly used in the same country. Am I right?

Most probably yes, unless there are some words included which need translation.
 I did not analyze that bug carefully.

-- 
You are receiving this mail because:
You are on the CC list for the bug.