From: Roland McGrath <roland@hack.frob.com>
To: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
Cc: carlos@redhat.com, aj@suse.com, libc-alpha@sourceware.org,
libc-ports@sourceware.org, naveen.n.rao@linux.vnet.ibm.com
Subject: Re: [PATCH] Update bits/siginfo.h with Linux hwpoison SIGBUS changes
Date: Fri, 17 May 2013 00:43:00 -0000 [thread overview]
Message-ID: <20130517004347.B2CD02C086@topped-with-meat.com> (raw)
In-Reply-To: Edjunior Barbosa Machado's message of Wednesday, 15 May 2013 03:51:23 -0300 <1368600683-11773-1-git-send-email-emachado@linux.vnet.ibm.com>
Always write 'short int', never just 'short'. Otherwise these seem fine to
me (assuming they match the new kernel definitions).
The ports changes technically need pro forma sign-off from four
maintainers. But I think it's good enough if you've triple-checked that
the new definitions match the kernel's for each machine, and wait a few
days to give them a chance to speak up, but go ahead and commit (say, on
Tuesday) for each port whose maintainer hasn't responded. You can commit
the common change now (and each port's change as soon as the maintainer
says), or wait to do them all together, at your pleasure.
Thanks,
Roland
next prev parent reply other threads:[~2013-05-17 0:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 4:47 Edjunior Barbosa Machado
2013-05-14 18:32 ` Edjunior Barbosa Machado
2013-05-14 19:38 ` Andreas Jaeger
2013-05-14 20:45 ` Carlos O'Donell
2013-05-15 6:53 ` Edjunior Barbosa Machado
2013-05-17 0:43 ` Roland McGrath [this message]
2013-05-18 7:17 ` Edjunior Barbosa Machado
2013-05-22 20:09 ` Edjunior Barbosa Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130517004347.B2CD02C086@topped-with-meat.com \
--to=roland@hack.frob.com \
--cc=aj@suse.com \
--cc=carlos@redhat.com \
--cc=emachado@linux.vnet.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-ports@sourceware.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).