Re: [PATCH] Update bits/siginfo.h with Linux hwpoison SIGBUS changes

[Andreas Jaeger <aj@suse.com>]

On 05/07/2013 06:45 AM, Edjunior Barbosa Machado wrote:
> This patch adds new SIGBUS error codes for hardware poison signals, syncing
> with the current kernel headers (v3.9). It also adds si_trapno field for alpha.
>
> Ok?

 > [...]
> --- a/sysdeps/unix/sysv/linux/x86/bits/siginfo.h
> +++ b/sysdeps/unix/sysv/linux/x86/bits/siginfo.h
> @@ -107,6 +107,7 @@ typedef struct
>   	struct
>   	  {
>   	    void *si_addr;	/* Faulting insn/memory ref.  */
> +	    short si_addr_lsb;	/* Valid LSB of the reported address */
We normally end comments with a "." and two spaces, see above.

Similar below and throughout the patch set. The code changes itself are 
fine.


>   	  } _sigfault;
>
>   	/* SIGPOLL.  */
> @@ -139,6 +140,7 @@ typedef struct
>   # define si_int		_sifields._rt.si_sigval.sival_int
>   # define si_ptr		_sifields._rt.si_sigval.sival_ptr
>   # define si_addr	_sifields._sigfault.si_addr
> +# define si_addr_lsb	_sifields._sigfault.si_addr_lsb
>   # define si_band	_sifields._sigpoll.si_band
>   # define si_fd		_sifields._sigpoll.si_fd
>   # define si_call_addr 	_sifields._sigsys._call_addr
> @@ -229,8 +231,12 @@ enum
>   # define BUS_ADRALN	BUS_ADRALN
>     BUS_ADRERR,			/* Non-existant physical address.  */
>   # define BUS_ADRERR	BUS_ADRERR
> -  BUS_OBJERR			/* Object specific hardware error.  */
> +  BUS_OBJERR,			/* Object specific hardware error.  */
>   # define BUS_OBJERR	BUS_OBJERR
> +  BUS_MCEERR_AR,		/* Hardware memory error: action required */

> +# define BUS_MCEERR_AR	BUS_MCEERR_AR
> +  BUS_MCEERR_AO			/* Hardware memory error: action optional */
> +# define BUS_MCEERR_AO	BUS_MCEERR_AO
>   };

The last two added comments have the same problem.
>
>   /* `si_code' values for SIGTRAP signal.  */
>

Could you update all the comments and resend, please?

Thanks,
Andreas
-- 
  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
   SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
    GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126