From: Jack Carter <Jack.Carter@imgtec.com>
To: Will Newton <will.newton@linaro.org>
Cc: "libc-ports@sourceware.org" <libc-ports@sourceware.org>,
"rdsandiford@googlemail.com" <rdsandiford@googlemail.com>
Subject: RE: [PATCH] 2nd round of Mips ifunc support
Date: Wed, 20 Nov 2013 21:15:00 -0000 [thread overview]
Message-ID: <4CEFBC1BE64A8048869F799EF2D2EEEE4C516E27@BADAG02.ba.imgtec.org> (raw)
In-Reply-To: <CANu=DmhpLyPf0H+XeSMp6OBYmTrsybh=U6D64pqz8nfQ-zKxyA@mail.gmail.com>
Will, Thanks for looking at this. My responses are below.
Jack
________________________________________
> From: Will Newton [will.newton@linaro.org]
> Sent: Saturday, November 16, 2013 3:06 AM
> To: Jack Carter
> Cc: libc-ports@sourceware.org; rdsandiford@googlemail.com
> Subject: Re: [PATCH] 2nd round of Mips ifunc support
>
> On 16 November 2013 00:41, Jack Carter <Jack.Carter@imgtec.com> wrote:
> > Attached is the second pass for Mips ifunc support in glibc.
> >
> > There is an abi attached as well.
>
> Your patch would be easier to review if it was posted inline with e.g.
> git-send-email.
Will do. I got reamed for using it for LLVM, but am learning the differences between
the 2 cultures.
>
> I don't think the vxworks comment in the commit message (or indeed the
> reference to micromips etc.) makes any sense in the context of glibc.
I will take them out.
>
> The use of __builtin_expect should be replaced with __glibc_unlikely.
I will make the changes.
>
> The example in your ABI doc should probably take an argument of the
> hwcap value rather than void.
I will make the changes.
>
> --
> Will Newton
> Toolchain Working Group, Linaro
prev parent reply other threads:[~2013-11-20 19:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-16 0:44 Jack Carter
2013-11-16 1:11 ` Jack Carter
2013-11-18 12:29 ` Will Newton
2013-11-20 21:15 ` Jack Carter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEFBC1BE64A8048869F799EF2D2EEEE4C516E27@BADAG02.ba.imgtec.org \
--to=jack.carter@imgtec.com \
--cc=libc-ports@sourceware.org \
--cc=rdsandiford@googlemail.com \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).