public inbox for
 help / color / mirror / Atom feed
From: Will Newton <>
To: Jack Carter <>
Cc: "" <>,
		"" <>
Subject: Re: [PATCH] 2nd round of Mips ifunc support
Date: Mon, 18 Nov 2013 12:29:00 -0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 16 November 2013 00:41, Jack Carter <> wrote:
> Attached is the second pass for Mips ifunc support in glibc.
> There is an abi attached as well.

Your patch would be easier to review if it was posted inline with e.g.

I don't think the vxworks comment in the commit message (or indeed the
reference to micromips etc.) makes any sense in the context of glibc.

The use of __builtin_expect should be replaced with __glibc_unlikely.

The example in your ABI doc should probably take an argument of the
hwcap value rather than void.

Will Newton
Toolchain Working Group, Linaro

  parent reply	other threads:[~2013-11-16 11:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-16  0:44 Jack Carter
2013-11-16  1:11 ` Jack Carter
2013-11-18 12:29 ` Will Newton [this message]
2013-11-20 21:15   ` Jack Carter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).