public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Grapentin <andreas@grapentin.org>
To: libc-ports@sourceware.org
Subject: [PATCH] [SUGGESTION?] remove obsolete case statement in configure.in
Date: Sun, 13 Jan 2013 19:32:00 -0000	[thread overview]
Message-ID: <50F30BB9.8090605@grapentin.org> (raw)

Hi,

I'm currently in the process of understanding the build process of
glibc, and during that I was reading, and trying to grasp the
configure.in file. Am I correct, that the attached patch transforms a
case with only one relevant branch into a (probably better to
understand) if statement  that makes more sense?

Cheers, Andy

diff --git a/configure.in b/configure.in
index 16497fa..7c908cc 100644
--- a/configure.in
+++ b/configure.in
@@ -327,13 +327,9 @@ AC_ARG_ENABLE([nscd],
 # i486-pc-linux-gnu fully from i486-pc-gnu.  So we mutate a $host_os
 # of `gnu*' here to be `gnu-gnu*' just so that shlib-versions can
 # tell.  This doesn't get used much beyond that, so it's fairly safe.
-case "$host_os" in
-linux*)
-  ;;
-gnu*)
+if test "$host_os" = gnu*; then
   host_os=`echo $host_os | sed -e 's/gnu/gnu-gnu/'`
-  ;;
-esac
+fi
 
 # We keep the original values in `$config_*' and never modify them, so we
 # can write them unchanged into config.make.  Everything else uses

             reply	other threads:[~2013-01-13 19:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-13 19:32 Andreas Grapentin [this message]
2013-01-13 19:38 ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F30BB9.8090605@grapentin.org \
    --to=andreas@grapentin.org \
    --cc=libc-ports@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).