[PATCH] [SUGGESTION?] remove obsolete case statement in configure.in

[PATCH] [SUGGESTION?] remove obsolete case statement in configure.in

[Andreas Grapentin]

Hi,

I'm currently in the process of understanding the build process of
glibc, and during that I was reading, and trying to grasp the
configure.in file. Am I correct, that the attached patch transforms a
case with only one relevant branch into a (probably better to
understand) if statement  that makes more sense?

Cheers, Andy

diff --git a/configure.in b/configure.in
index 16497fa..7c908cc 100644
--- a/configure.in
+++ b/configure.in
@@ -327,13 +327,9 @@ AC_ARG_ENABLE([nscd],
 # i486-pc-linux-gnu fully from i486-pc-gnu.  So we mutate a $host_os
 # of `gnu*' here to be `gnu-gnu*' just so that shlib-versions can
 # tell.  This doesn't get used much beyond that, so it's fairly safe.
-case "$host_os" in
-linux*)
-  ;;
-gnu*)
+if test "$host_os" = gnu*; then
   host_os=`echo $host_os | sed -e 's/gnu/gnu-gnu/'`
-  ;;
-esac
+fi
 
 # We keep the original values in `$config_*' and never modify them, so we
 # can write them unchanged into config.make.  Everything else uses

Re: [PATCH] [SUGGESTION?] remove obsolete case statement in configure.in

[Andreas Schwab]

Andreas Grapentin <andreas@grapentin.org> writes:

> +if test "$host_os" = gnu*; then

test doesn't do pattern matching.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."