From: Richard Henderson <rth@twiddle.net>
To: Roland McGrath <roland@hack.frob.com>
Cc: libc-ports@sourceware.org
Subject: Re: [PATCH roland/arm-memcpy] ARM: Make multiarch memcpy always use NEON when compiler does
Date: Tue, 14 May 2013 15:47:00 -0000 [thread overview]
Message-ID: <51925C9B.2030307@twiddle.net> (raw)
In-Reply-To: <20130513224722.9F17C2C05E@topped-with-meat.com>
On 05/13/2013 03:47 PM, Roland McGrath wrote:
> IFUNC_IMPL (i, name, memcpy,
> IFUNC_IMPL_ADD (array, i, memcpy, hwcap & HWCAP_ARM_NEON,
> - __memcpy_neon)
> +#ifdef __ARM_NEON__
> + memcpy
> +#else
> + __memcpy_neon
> +#endif
> + )
> +#ifndef __ARM_NEON__
> IFUNC_IMPL_ADD (array, i, memcpy, hwcap & HWCAP_ARM_VFP,
> __memcpy_vfp)
> +#endif
> IFUNC_IMPL_ADD (array, i, memcpy, 1, __memcpy_arm));
I think you're better off leaving the __memcpy_neon symbol in all cases.
Having memcpy be an alias to __memcpy_neon would make the rest of the patch
simpler.
r~
next prev parent reply other threads:[~2013-05-14 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 22:47 Roland McGrath
2013-05-13 23:12 ` Joseph S. Myers
2013-05-14 7:47 ` Andreas Schwab
2013-05-17 0:31 ` Roland McGrath
2013-05-14 15:47 ` Richard Henderson [this message]
2013-05-17 0:32 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51925C9B.2030307@twiddle.net \
--to=rth@twiddle.net \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).