From: Andreas Schwab <schwab@suse.de>
To: Roland McGrath <roland@hack.frob.com>
Cc: libc-ports@sourceware.org
Subject: Re: [PATCH roland/arm-memcpy] ARM: Make multiarch memcpy always use NEON when compiler does
Date: Tue, 14 May 2013 07:47:00 -0000 [thread overview]
Message-ID: <mvmip2mype2.fsf@hawking.suse.de> (raw)
In-Reply-To: <20130513224722.9F17C2C05E@topped-with-meat.com> (Roland McGrath's message of "Mon, 13 May 2013 15:47:22 -0700 (PDT)")
Roland McGrath <roland@hack.frob.com> writes:
> IFUNC_IMPL (i, name, memcpy,
> IFUNC_IMPL_ADD (array, i, memcpy, hwcap & HWCAP_ARM_NEON,
> - __memcpy_neon)
> +#ifdef __ARM_NEON__
> + memcpy
> +#else
> + __memcpy_neon
> +#endif
> + )
Preprocessor directives in macro arguments give undefined behaviour.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2013-05-14 7:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 22:47 Roland McGrath
2013-05-13 23:12 ` Joseph S. Myers
2013-05-14 7:47 ` Andreas Schwab [this message]
2013-05-17 0:31 ` Roland McGrath
2013-05-14 15:47 ` Richard Henderson
2013-05-17 0:32 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmip2mype2.fsf@hawking.suse.de \
--to=schwab@suse.de \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).