From: Thomas Schwinge <thomas@codesourcery.com>
To: Andreas Jaeger <aj@suse.com>,
"Joseph S. Myers" <joseph@codesourcery.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: [PATCH 5/6] Use bits/mman-linux.h for MIPS
Date: Mon, 11 Mar 2013 12:20:00 -0000 [thread overview]
Message-ID: <871ubmxh5i.fsf@kepler.schwinge.homeip.net> (raw)
In-Reply-To: <5137652E.5010803@suse.com>
[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]
Hi!
On Wed, 06 Mar 2013 16:47:58 +0100, Andreas Jaeger <aj@suse.com> wrote:
> 2013-03-06 Andreas Jaeger <aj@suse.de>
>
> * sysdeps/unix/sysv/linux/bits/mman-linux.h (MAP_ANONYMOUS): Allow
> definition via __MAP_ANONYMOUS.
>
> ChangeLog.mips:
> * sysdeps/unix/sysv/linux/mips/bits/mman.h: Remove all defines
> provided by bits/mman-linux.h and include <bits/mman-linux.h>.
> (__MAP_ANONYMOUS): Define.
With the current master branch (including this change as commit
664a9ce4ca40feabff781fff044c93a43ae15b59), I get redefinition warnings
for MAP_ANONYMOUS; solved by the following patch. OK to push?
ports/ChangeLog.mips
* sysdeps/unix/sysv/linux/mips/bits/mman.h [__USE_MISC]
(MAP_ANONYMOUS): Don't define.
diff --git ports/sysdeps/unix/sysv/linux/mips/bits/mman.h ports/sysdeps/unix/sysv/linux/mips/bits/mman.h
index 883f947..b327795 100644
--- ports/sysdeps/unix/sysv/linux/mips/bits/mman.h
+++ ports/sysdeps/unix/sysv/linux/mips/bits/mman.h
@@ -26,7 +26,6 @@
/* These are Linux-specific. */
#ifdef __USE_MISC
# define MAP_NORESERVE 0x0400 /* don't check for reservations */
-# define MAP_ANONYMOUS 0x0800 /* don't use a file */
# define MAP_GROWSDOWN 0x1000 /* stack-like segment */
# define MAP_DENYWRITE 0x2000 /* ETXTBSY */
# define MAP_EXECUTABLE 0x4000 /* mark it as an executable */
Grüße,
Thomas
[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]
next prev parent reply other threads:[~2013-03-11 12:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 19:53 [PATCH 0/6] Use common <bits/mman-linux.h> for various ports Andreas Jaeger
2013-03-05 19:37 ` [PATCH 6/6] Use bits/mman-linux.h for TILE Andreas Jaeger
2013-03-05 19:48 ` Chris Metcalf
2013-03-05 19:37 ` [PATCH 4/6] Use bits/mman-linux.h for M68K Andreas Jaeger
2013-03-05 22:55 ` Andreas Schwab
2013-03-05 19:37 ` [PATCH 1/6] Use bits/mman-linux.h for AM33 Andreas Jaeger
2013-03-05 19:37 ` [PATCH 2/6] Use bits/mman-linux.h for ARM Andreas Jaeger
2013-03-05 23:36 ` Joseph S. Myers
2013-03-05 19:37 ` [PATCH 3/6] Use bits/mman-linux.h for IA64 Andreas Jaeger
2013-03-10 14:58 ` Andreas Jaeger
2013-03-10 21:52 ` Mike Frysinger
2013-03-05 19:53 ` [PATCH 5/6] Use bits/mman-linux.h for MIPS Andreas Jaeger
2013-03-05 23:39 ` Joseph S. Myers
2013-03-06 8:25 ` Andreas Jaeger
2013-03-06 15:48 ` Andreas Jaeger
2013-03-06 16:33 ` Joseph S. Myers
2013-03-06 16:39 ` Andreas Jaeger
2013-03-11 12:20 ` Thomas Schwinge [this message]
2013-03-11 13:17 ` Andreas Jaeger
2013-03-11 15:12 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ubmxh5i.fsf@kepler.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=aj@suse.com \
--cc=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).