Re: [PATCH 5/6] Use bits/mman-linux.h for MIPS

[Andreas Jaeger <aj@suse.com>]

[-- Attachment #1: Type: text/plain, Size: 1903 bytes --]

On Monday, March 11, 2013 13:19:53 Thomas Schwinge wrote:
> Hi!
> 
> On Wed, 06 Mar 2013 16:47:58 +0100, Andreas Jaeger <aj@suse.com> 
wrote:
> > 2013-03-06  Andreas Jaeger  <aj@suse.de>
> > 
> > 	* sysdeps/unix/sysv/linux/bits/mman-linux.h (MAP_ANONYMOUS): 
Allow
> > 	definition via __MAP_ANONYMOUS.
> > 	
> > 	ChangeLog.mips:
> > 	* sysdeps/unix/sysv/linux/mips/bits/mman.h: Remove all defines
> > 	provided by bits/mman-linux.h and include <bits/mman-linux.h>.
> > 	(__MAP_ANONYMOUS): Define.
> 
> With the current master branch (including this change as commit
> 664a9ce4ca40feabff781fff044c93a43ae15b59), I get redefinition warnings
> for MAP_ANONYMOUS; solved by the following patch.  OK to push?
> 
> ports/ChangeLog.mips
> 	* sysdeps/unix/sysv/linux/mips/bits/mman.h [__USE_MISC]
> 	(MAP_ANONYMOUS): Don't define.
> 
> diff --git ports/sysdeps/unix/sysv/linux/mips/bits/mman.h
> ports/sysdeps/unix/sysv/linux/mips/bits/mman.h index 883f947..b327795
> 100644
> --- ports/sysdeps/unix/sysv/linux/mips/bits/mman.h
> +++ ports/sysdeps/unix/sysv/linux/mips/bits/mman.h
> @@ -26,7 +26,6 @@
>  /* These are Linux-specific.  */
>  #ifdef __USE_MISC
>  # define MAP_NORESERVE	0x0400		/* don't check for 
reservations */
> -# define MAP_ANONYMOUS	0x0800		/* don't use a file */
>  # define MAP_GROWSDOWN	0x1000		/* stack-like segment */
>  # define MAP_DENYWRITE	0x2000		/* ETXTBSY */
>  # define MAP_EXECUTABLE	0x4000		/* mark it as an executable */

Yes, that was the intention - to remove this define.

I would consider this an obvious cleanup,

Thanks,
Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 190 bytes --]