From: Andreas Jaeger <aj@suse.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: libc-ports@sourceware.org
Subject: Re: [PATCH 5/6] Use bits/mman-linux.h for MIPS
Date: Wed, 06 Mar 2013 16:39:00 -0000 [thread overview]
Message-ID: <5137711E.8010503@suse.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1303061631560.12534@digraph.polyomino.org.uk>
On 03/06/2013 05:33 PM, Joseph S. Myers wrote:
> On Wed, 6 Mar 2013, Andreas Jaeger wrote:
>
>> Here's an updated patch, ok now?
>>
>> Andreas
>>
>> 2013-03-06 Andreas Jaeger <aj@suse.de>
>>
>> * sysdeps/unix/sysv/linux/bits/mman-linux.h (MAP_ANONYMOUS): Allow
>> definition via __MAP_ANONYMOUS.
>>
>> ChangeLog.mips:
>> * sysdeps/unix/sysv/linux/mips/bits/mman.h: Remove all defines
>> provided by bits/mman-linux.h and include <bits/mman-linux.h>.
>> (__MAP_ANONYMOUS): Define.
>
> OK. In general I think defining __* names ought to be the right approach
> for architectures with more substantial differences in the values as well,
> so that the architecture-specific headers never need to concern themselves
> with the feature-test macros that determine when to expose non-__* names
> to the user.
Yes, further cleanup steps are possible here.
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
next prev parent reply other threads:[~2013-03-06 16:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 19:53 [PATCH 0/6] Use common <bits/mman-linux.h> for various ports Andreas Jaeger
2013-03-05 19:37 ` [PATCH 2/6] Use bits/mman-linux.h for ARM Andreas Jaeger
2013-03-05 23:36 ` Joseph S. Myers
2013-03-05 19:37 ` [PATCH 3/6] Use bits/mman-linux.h for IA64 Andreas Jaeger
2013-03-10 14:58 ` Andreas Jaeger
2013-03-10 21:52 ` Mike Frysinger
2013-03-05 19:37 ` [PATCH 6/6] Use bits/mman-linux.h for TILE Andreas Jaeger
2013-03-05 19:48 ` Chris Metcalf
2013-03-05 19:37 ` [PATCH 4/6] Use bits/mman-linux.h for M68K Andreas Jaeger
2013-03-05 22:55 ` Andreas Schwab
2013-03-05 19:37 ` [PATCH 1/6] Use bits/mman-linux.h for AM33 Andreas Jaeger
2013-03-05 19:53 ` [PATCH 5/6] Use bits/mman-linux.h for MIPS Andreas Jaeger
2013-03-05 23:39 ` Joseph S. Myers
2013-03-06 8:25 ` Andreas Jaeger
2013-03-06 15:48 ` Andreas Jaeger
2013-03-06 16:33 ` Joseph S. Myers
2013-03-06 16:39 ` Andreas Jaeger [this message]
2013-03-11 12:20 ` Thomas Schwinge
2013-03-11 13:17 ` Andreas Jaeger
2013-03-11 15:12 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5137711E.8010503@suse.com \
--to=aj@suse.com \
--cc=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).