* [Patch][AArch64] Use generic "mcount" routine for profiling.
@ 2013-05-20 17:11 Venkataramanan Kumar
2013-05-22 8:38 ` Marcus Shawcroft
0 siblings, 1 reply; 4+ messages in thread
From: Venkataramanan Kumar @ 2013-05-20 17:11 UTC (permalink / raw)
To: libc-ports; +Cc: Marcus Shawcroft, Patch Tracking
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
Hi Maintainers,
The attached patch removes "machine-gmon.h" file under aarch64 which
is supposed to define custom "mcount" routine.
Instead the plan is to use the generic version of the "mcount" routine
which glibc already provides.
I have submitted a GCC patch that is needed to emit "_mcount" and set
up the frame.
ref: http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00597.html
This is under review/discussion.
ChangeLog
2013-05-20 Venkataranmanan Kumar <venkataramanan.kumar@linaro.org>
* sysdeps/aarch64/machine-gmon.h: Remove.
ok for trunk?
regards,
Venkat.
[-- Attachment #2: remove-mcount.diff --]
[-- Type: application/octet-stream, Size: 1294 bytes --]
diff --git a/ports/sysdeps/aarch64/machine-gmon.h b/ports/sysdeps/aarch64/machine-gmon.h
deleted file mode 100644
index c52a1a4..0000000
--- a/ports/sysdeps/aarch64/machine-gmon.h
+++ /dev/null
@@ -1,25 +0,0 @@
-/* Copyright (C) 2011-2013 Free Software Foundation, Inc.
-
- This file is part of the GNU C Library.
-
- The GNU C Library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Lesser General Public
- License as published by the Free Software Foundation; either
- version 2.1 of the License, or (at your option) any later version.
-
- The GNU C Library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Lesser General Public License for more details.
-
- You should have received a copy of the GNU Lesser General Public
- License along with the GNU C Library. If not, see
- <http://www.gnu.org/licenses/>. */
-
-#define _MCOUNT_DECL(from, self) \
- void __mcount_internal (u_long from, u_long self)
-
-/* Call __mcount_internal with our the return PC for our caller, and
- the return PC our caller will return to. Empty since we use an
- assembly stub instead. */
-#define MCOUNT
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch][AArch64] Use generic "mcount" routine for profiling.
2013-05-20 17:11 [Patch][AArch64] Use generic "mcount" routine for profiling Venkataramanan Kumar
@ 2013-05-22 8:38 ` Marcus Shawcroft
2013-05-23 7:33 ` Venkataramanan Kumar
0 siblings, 1 reply; 4+ messages in thread
From: Marcus Shawcroft @ 2013-05-22 8:38 UTC (permalink / raw)
To: Venkataramanan Kumar; +Cc: libc-ports, Patch Tracking
Looks OK to me.
/Marcus
On 20 May 2013 18:11, Venkataramanan Kumar
<venkataramanan.kumar@linaro.org> wrote:
> Hi Maintainers,
>
> The attached patch removes "machine-gmon.h" file under aarch64 which
> is supposed to define custom "mcount" routine.
> Instead the plan is to use the generic version of the "mcount" routine
> which glibc already provides.
>
> I have submitted a GCC patch that is needed to emit "_mcount" and set
> up the frame.
> ref: http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00597.html
>
> This is under review/discussion.
>
> ChangeLog
>
> 2013-05-20 Venkataranmanan Kumar <venkataramanan.kumar@linaro.org>
> * sysdeps/aarch64/machine-gmon.h: Remove.
>
> ok for trunk?
>
> regards,
> Venkat.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch][AArch64] Use generic "mcount" routine for profiling.
2013-05-22 8:38 ` Marcus Shawcroft
@ 2013-05-23 7:33 ` Venkataramanan Kumar
2013-05-23 13:48 ` Marcus Shawcroft
0 siblings, 1 reply; 4+ messages in thread
From: Venkataramanan Kumar @ 2013-05-23 7:33 UTC (permalink / raw)
To: Marcus Shawcroft; +Cc: libc-ports, Patch Tracking
Hi Marcus,
I don't have write access, can someone commit on my behalf.
regards,
Venkat
On 22 May 2013 14:08, Marcus Shawcroft <marcus.shawcroft@linaro.org> wrote:
> Looks OK to me.
> /Marcus
>
> On 20 May 2013 18:11, Venkataramanan Kumar
> <venkataramanan.kumar@linaro.org> wrote:
>> Hi Maintainers,
>>
>> The attached patch removes "machine-gmon.h" file under aarch64 which
>> is supposed to define custom "mcount" routine.
>> Instead the plan is to use the generic version of the "mcount" routine
>> which glibc already provides.
>>
>> I have submitted a GCC patch that is needed to emit "_mcount" and set
>> up the frame.
>> ref: http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00597.html
>>
>> This is under review/discussion.
>>
>> ChangeLog
>>
>> 2013-05-20 Venkataranmanan Kumar <venkataramanan.kumar@linaro.org>
>> * sysdeps/aarch64/machine-gmon.h: Remove.
>>
>> ok for trunk?
>>
>> regards,
>> Venkat.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch][AArch64] Use generic "mcount" routine for profiling.
2013-05-23 7:33 ` Venkataramanan Kumar
@ 2013-05-23 13:48 ` Marcus Shawcroft
0 siblings, 0 replies; 4+ messages in thread
From: Marcus Shawcroft @ 2013-05-23 13:48 UTC (permalink / raw)
To: Venkataramanan Kumar; +Cc: libc-ports, Patch Tracking
On 23 May 2013 08:33, Venkataramanan Kumar
<venkataramanan.kumar@linaro.org> wrote:
> Hi Marcus,
>
> I don't have write access, can someone commit on my behalf.
>
> regards,
> Venkat
Committed.
Thanks
/Marcus
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-23 13:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-20 17:11 [Patch][AArch64] Use generic "mcount" routine for profiling Venkataramanan Kumar
2013-05-22 8:38 ` Marcus Shawcroft
2013-05-23 7:33 ` Venkataramanan Kumar
2013-05-23 13:48 ` Marcus Shawcroft
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).