[Patch][AArch64] Use generic "mcount" routine for profiling.

[Patch][AArch64] Use generic "mcount" routine for profiling.

[Venkataramanan Kumar]

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

Hi Maintainers,

The attached patch removes  "machine-gmon.h" file under aarch64 which
is supposed to define custom "mcount" routine.
Instead the plan is to use the generic version of the "mcount" routine
which glibc already provides.

I have submitted a GCC patch that is needed to emit "_mcount" and set
up the frame.
ref: http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00597.html

This is under review/discussion.

ChangeLog

2013-05-20  Venkataranmanan Kumar <venkataramanan.kumar@linaro.org>
       * sysdeps/aarch64/machine-gmon.h: Remove.

ok for trunk?

regards,
Venkat.

[-- Attachment #2: remove-mcount.diff --]
[-- Type: application/octet-stream, Size: 1294 bytes --]

diff --git a/ports/sysdeps/aarch64/machine-gmon.h b/ports/sysdeps/aarch64/machine-gmon.h
deleted file mode 100644
index c52a1a4..0000000
--- a/ports/sysdeps/aarch64/machine-gmon.h
+++ /dev/null
@@ -1,25 +0,0 @@
-/* Copyright (C) 2011-2013 Free Software Foundation, Inc.
-
-   This file is part of the GNU C Library.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library.  If not, see
-   <http://www.gnu.org/licenses/>.  */
-
-#define _MCOUNT_DECL(from, self) \
- void __mcount_internal (u_long from, u_long self)
-
-/* Call __mcount_internal with our the return PC for our caller, and
-   the return PC our caller will return to.  Empty since we use an
-   assembly stub instead. */
-#define MCOUNT

Re: [Patch][AArch64] Use generic "mcount" routine for profiling.

[Marcus Shawcroft]

Looks OK to me.
/Marcus

On 20 May 2013 18:11, Venkataramanan Kumar
<venkataramanan.kumar@linaro.org> wrote:
> Hi Maintainers,
>
> The attached patch removes  "machine-gmon.h" file under aarch64 which
> is supposed to define custom "mcount" routine.
> Instead the plan is to use the generic version of the "mcount" routine
> which glibc already provides.
>
> I have submitted a GCC patch that is needed to emit "_mcount" and set
> up the frame.
> ref: http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00597.html
>
> This is under review/discussion.
>
> ChangeLog
>
> 2013-05-20  Venkataranmanan Kumar <venkataramanan.kumar@linaro.org>
>        * sysdeps/aarch64/machine-gmon.h: Remove.
>
> ok for trunk?
>
> regards,
> Venkat.

Re: [Patch][AArch64] Use generic "mcount" routine for profiling.

[Venkataramanan Kumar]

Hi Marcus,

I don't have write access, can someone commit on my behalf.

regards,
Venkat


On 22 May 2013 14:08, Marcus Shawcroft <marcus.shawcroft@linaro.org> wrote:
> Looks OK to me.
> /Marcus
>
> On 20 May 2013 18:11, Venkataramanan Kumar
> <venkataramanan.kumar@linaro.org> wrote:
>> Hi Maintainers,
>>
>> The attached patch removes  "machine-gmon.h" file under aarch64 which
>> is supposed to define custom "mcount" routine.
>> Instead the plan is to use the generic version of the "mcount" routine
>> which glibc already provides.
>>
>> I have submitted a GCC patch that is needed to emit "_mcount" and set
>> up the frame.
>> ref: http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00597.html
>>
>> This is under review/discussion.
>>
>> ChangeLog
>>
>> 2013-05-20  Venkataranmanan Kumar <venkataramanan.kumar@linaro.org>
>>        * sysdeps/aarch64/machine-gmon.h: Remove.
>>
>> ok for trunk?
>>
>> regards,
>> Venkat.

Re: [Patch][AArch64] Use generic "mcount" routine for profiling.

[Marcus Shawcroft]

On 23 May 2013 08:33, Venkataramanan Kumar
<venkataramanan.kumar@linaro.org> wrote:
> Hi Marcus,
>
> I don't have write access, can someone commit on my behalf.
>
> regards,
> Venkat

Committed.

Thanks
/Marcus