* Patch for MIPS PREF/PREFX macro definitions
@ 2012-07-31 22:59 Steve Ellcey
2012-08-01 15:13 ` Joseph S. Myers
0 siblings, 1 reply; 2+ messages in thread
From: Steve Ellcey @ 2012-07-31 22:59 UTC (permalink / raw)
To: libc-ports
I was wondering if someone could check in this obvious fix for MIPS.
The code is supposed to define the PREF and PREFX macro calls as nothing
when on a machine that doesn't support prefetching but the empty
definitions don't include the argument lists and that causes the
arguments to show up in the code which is wrong.
Steve Ellcey
sellcey@mips.com
Here is the patch:
2012-07-31 Steve Ellcey <sellcey@mips.com>
* sysdeps/mips/sys/asm.h: Fix PREF and PREFX definitions.
diff --git a/ports/sysdeps/mips/sys/asm.h b/ports/sysdeps/mips/sys/asm.h
index 347d738..0f5edf9 100644
--- a/ports/sysdeps/mips/sys/asm.h
+++ b/ports/sysdeps/mips/sys/asm.h
@@ -233,8 +233,8 @@ symbol = value
# define PREFX(hint,addr) \
prefx hint,addr
#else
-# define PREF
-# define PREFX
+# define PREF(hint,addr)
+# define PREFX(hint,addr)
#endif
/*
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Patch for MIPS PREF/PREFX macro definitions
2012-07-31 22:59 Patch for MIPS PREF/PREFX macro definitions Steve Ellcey
@ 2012-08-01 15:13 ` Joseph S. Myers
0 siblings, 0 replies; 2+ messages in thread
From: Joseph S. Myers @ 2012-08-01 15:13 UTC (permalink / raw)
To: Steve Ellcey; +Cc: libc-ports
On Tue, 31 Jul 2012, Steve Ellcey wrote:
> I was wondering if someone could check in this obvious fix for MIPS.
> The code is supposed to define the PREF and PREFX macro calls as nothing
> when on a machine that doesn't support prefetching but the empty
> definitions don't include the argument lists and that causes the
> arguments to show up in the code which is wrong.
Thanks, I've applied this patch (with the ChangeLog entry adjusted).
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-01 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-31 22:59 Patch for MIPS PREF/PREFX macro definitions Steve Ellcey
2012-08-01 15:13 ` Joseph S. Myers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).