* [PATCH] ARM: fix preconfigure
@ 2013-03-25 12:58 Mans Rullgard
2013-03-26 20:53 ` Joseph S. Myers
0 siblings, 1 reply; 2+ messages in thread
From: Mans Rullgard @ 2013-03-25 12:58 UTC (permalink / raw)
To: libc-ports
After the conversion to autoconf, m4 eats the square brackets causing
CFLAGS to be unconditionally reset. Using 'test' instead of brackets
fixes this.
'preconfigure' manually updated as I have no desire to spend time installing
the precise autofoo versions required.
---
ports/sysdeps/arm/preconfigure | 2 +-
ports/sysdeps/arm/preconfigure.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ports/sysdeps/arm/preconfigure b/ports/sysdeps/arm/preconfigure
index 7ba1749..908cd34 100644
--- a/ports/sysdeps/arm/preconfigure
+++ b/ports/sysdeps/arm/preconfigure
@@ -10,7 +10,7 @@ arm*)
# avoid this, add -fno-unwind-tables here and remove it in
# sysdeps/unix/sysv/linux/arm/configure.in after those tests have
# been run.
- if "${CFLAGS+set}" != "set" ; then
+ if test "${CFLAGS+set}" != "set"; then
CFLAGS="-g -O2"
fi
CFLAGS="$CFLAGS -fno-unwind-tables"
diff --git a/ports/sysdeps/arm/preconfigure.in b/ports/sysdeps/arm/preconfigure.in
index 99f2128..f835795 100644
--- a/ports/sysdeps/arm/preconfigure.in
+++ b/ports/sysdeps/arm/preconfigure.in
@@ -10,7 +10,7 @@ arm*)
# avoid this, add -fno-unwind-tables here and remove it in
# sysdeps/unix/sysv/linux/arm/configure.in after those tests have
# been run.
- if [ "${CFLAGS+set}" != "set" ]; then
+ if test "${CFLAGS+set}" != "set"; then
CFLAGS="-g -O2"
fi
CFLAGS="$CFLAGS -fno-unwind-tables"
--
1.8.1.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: fix preconfigure
2013-03-25 12:58 [PATCH] ARM: fix preconfigure Mans Rullgard
@ 2013-03-26 20:53 ` Joseph S. Myers
0 siblings, 0 replies; 2+ messages in thread
From: Joseph S. Myers @ 2013-03-26 20:53 UTC (permalink / raw)
To: Mans Rullgard; +Cc: libc-ports
Thanks, committed.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-26 20:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-25 12:58 [PATCH] ARM: fix preconfigure Mans Rullgard
2013-03-26 20:53 ` Joseph S. Myers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).