public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Siddhesh Poyarekar <siddhesh@redhat.com>
Cc: <libc-alpha@sourceware.org>, <libc-ports@sourceware.org>
Subject: Re: [PATCH][BZ #14412] Define __sincos_finite as a fast version of sincos
Date: Mon, 29 Apr 2013 13:34:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.64.1304291332320.10827@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20130429102739.GE1330@spoyarek.pnq.redhat.com>

On Mon, 29 Apr 2013, Siddhesh Poyarekar wrote:

> This patch brings back the assembly implementation of sincos (with
> some changes) to give a fast alternative to the default sincos
> implementation.  This is defined as __sincos_finite and is used if the
> implementing program is compiled with the -ffinite-math-only gcc flag.

The changes don't seem to include accurate range reduction.  Without that, 
I think this is inappropriate, as it will result in wildly inaccurate 
results for large but finite inputs.

(I've stated before that all libm tests with finite inputs and outputs 
should be run with -ffinite-math-only - and I consider that they should 
pass when they pass without that option, and should not need different 
ulps for the different ways of running them.)

-- 
Joseph S. Myers
joseph@codesourcery.com

  parent reply	other threads:[~2013-04-29 13:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-29 10:26 Siddhesh Poyarekar
2013-04-29 13:31 ` Andreas Schwab
2013-04-29 13:34 ` Joseph S. Myers [this message]
2013-04-29 14:02   ` Siddhesh Poyarekar
2013-04-29 14:16   ` Ondřej Bílka
2013-04-29 14:53     ` Andrew Haley
2013-04-29 15:19       ` Rich Felker
2013-04-30  8:59 ` Ondřej Bílka
2013-04-30  9:03   ` Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1304291332320.10827@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=libc-ports@sourceware.org \
    --cc=siddhesh@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).