From: Andreas Schwab <schwab@linux-m68k.org>
To: Siddhesh Poyarekar <siddhesh@redhat.com>
Cc: libc-alpha@sourceware.org, libc-ports@sourceware.org
Subject: Re: [PATCH][BZ #14412] Define __sincos_finite as a fast version of sincos
Date: Mon, 29 Apr 2013 13:31:00 -0000 [thread overview]
Message-ID: <m2fvy9v4xq.fsf@igel.home> (raw)
In-Reply-To: <20130429102739.GE1330@spoyarek.pnq.redhat.com> (Siddhesh Poyarekar's message of "Mon, 29 Apr 2013 15:57:40 +0530")
Siddhesh Poyarekar <siddhesh@redhat.com> writes:
> This patch brings back the assembly implementation of sincos (with
> some changes) to give a fast alternative to the default sincos
> implementation. This is defined as __sincos_finite and is used if the
> implementing program is compiled with the -ffinite-math-only gcc flag.
This is the wrong approach. The bug is not about not handling Inf or
NaN in sincos, but allowing inaccurate result from certain finite
numbers. The -ffinite-math-only switch does not cover the latter.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2013-04-29 13:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 10:26 Siddhesh Poyarekar
2013-04-29 13:31 ` Andreas Schwab [this message]
2013-04-29 13:34 ` Joseph S. Myers
2013-04-29 14:02 ` Siddhesh Poyarekar
2013-04-29 14:16 ` Ondřej Bílka
2013-04-29 14:53 ` Andrew Haley
2013-04-29 15:19 ` Rich Felker
2013-04-30 8:59 ` Ondřej Bílka
2013-04-30 9:03 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2fvy9v4xq.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=libc-alpha@sourceware.org \
--cc=libc-ports@sourceware.org \
--cc=siddhesh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).