public inbox for
 help / color / mirror / Atom feed
From: "Joseph S. Myers" <>
To: Andrew Stubbs <>
Cc: <>
Subject: Re: [PATCH] PAGE_SIZE definition for MIPS XLP
Date: Mon, 18 Nov 2013 13:45:00 -0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, 18 Nov 2013, Andrew Stubbs wrote:

> The attached patch makes the definition conditional, rather than removing it
> completely. It's not clear to me whether the HOST_* definitions are similarly
> affected, but other platforms that do not define PAGE_SIZE also choose not to
> define those, so I've extended the ifndef similarly.
> I this OK to commit? Should it be solved a different way?

This should be raised on libc-alpha, not libc-ports, as it's a generic 
issue regarding what the glibc API is for PAGE_SIZE being provided or not 
provided in sys/user.h.

It's definitely wrong to test _MIPS_ARCH_XLP like that - glibc built for 
generic MIPS should work on all MIPS variants supporting all the 
instructions used in that glibc binary, so the fact that MIPS has variable 
page sizes means it's always wrong for MIPS glibc to embed a page size 
assumption in the binaries.  The question is whether PAGE_SIZE must only 
be defined when it is the kernel page size, or whether it should also be 
defined in some cases when it's some form of ABI page size even when that 
differs from the kernel page size.  I also see no rationale given for 
making any of the other macros conditional.

At least MicroBlaze also has variable kernel page size but defines 
PAGE_SIZE in sys/user.h.

Joseph S. Myers

  parent reply	other threads:[~2013-11-18 13:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18 12:51 Andrew Stubbs
2013-11-18 13:42 ` Andreas Schwab
2013-11-19 20:56   ` Maciej W. Rozycki
2013-11-18 13:45 ` Joseph S. Myers [this message]
2013-11-18 18:21 ` Joseph S. Myers
2013-11-19  3:28 ` Andrew Pinski
2013-11-19 14:57   ` Joseph S. Myers
2013-11-19 20:19     ` Andrew Stubbs
2013-11-20 19:57   ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).