* Re: [Backport: v2 0/7] Update _dl_tlsdesc_dynamic to preserve caller-saved registers
@ 2024-04-03 17:22 Arjun Shankar
0 siblings, 0 replies; 3+ messages in thread
From: Arjun Shankar @ 2024-04-03 17:22 UTC (permalink / raw)
To: libc-stable; +Cc: H.J. Lu
Hi H.J.,
I went through this patch series [1] and it looks OK for 2.39.
I looked through master for related changes and nothing relevant seems
to be missing.
[1] https://sourceware.org/pipermail/libc-stable/2024-April/001880.html
--
Arjun Shankar
he/him/his
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Backport: v2 0/7] Update _dl_tlsdesc_dynamic to preserve caller-saved registers
2024-04-02 13:27 H.J. Lu
@ 2024-04-03 22:32 ` Sunil Pandey
0 siblings, 0 replies; 3+ messages in thread
From: Sunil Pandey @ 2024-04-03 22:32 UTC (permalink / raw)
To: H.J. Lu; +Cc: libc-stable, fweimer, adhemerval.zanella, carlos, goldstein.w.n
[-- Attachment #1: Type: text/plain, Size: 4841 bytes --]
On Tue, Apr 2, 2024 at 6:27 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> Changes in v2:
>
> 1. Add tst-gnu2-tls2mod1 to test-internal-extras.
>
> ---
> GNU2 TLS descriptor instruction sequences have implicit _dl_tlsdesc_dynamic
> call and compilers assume that caller-saved registers are unchanged after
> call. Update _dl_tlsdesc_dynamic to preserve caller-saved registers.
>
> Adhemerval Zanella (3):
> Ignore undefined symbols for -mtls-dialect=gnu2
> arm: Update _dl_tlsdesc_dynamic to preserve caller-saved registers (BZ
> 31372)
> elf: Enable TLS descriptor tests on aarch64
>
> Andreas Schwab (1):
> Add tst-gnu2-tls2mod1 to test-internal-extras
>
> H.J. Lu (3):
> x86: Update _dl_tlsdesc_dynamic to preserve caller-saved registers
> x86-64: Update _dl_tlsdesc_dynamic to preserve AMX registers
> x86-64: Allocate state buffer space for RDI, RSI and RBX
>
> config.h.in | 3 +
> configure | 25 ++-
> configure.ac | 17 +-
> elf/Makefile | 34 +++-
> elf/tst-gnu2-tls2.c | 122 +++++++++++
> elf/tst-gnu2-tls2.h | 40 ++++
> elf/tst-gnu2-tls2mod0.c | 32 +++
> elf/tst-gnu2-tls2mod1.c | 32 +++
> elf/tst-gnu2-tls2mod2.c | 32 +++
> sysdeps/aarch64/preconfigure | 1 +
> sysdeps/arm/Makefile | 8 +-
> sysdeps/arm/configure | 32 +++
> sysdeps/arm/configure.ac | 15 ++
> sysdeps/arm/dl-tlsdesc.S | 70 ++++++-
> sysdeps/arm/tst-gnu2-tls2.h | 128 ++++++++++++
> sysdeps/i386/dl-machine.h | 2 +-
> sysdeps/i386/dl-tlsdesc-dynamic.h | 190 ++++++++++++++++++
> sysdeps/i386/dl-tlsdesc.S | 115 +++++------
> sysdeps/unix/sysv/linux/x86_64/Makefile | 27 +++
> .../sysv/linux/x86_64/include/asm/prctl.h | 5 +
> .../linux/x86_64/tst-gnu2-tls2-amx-mod0.c | 2 +
> .../linux/x86_64/tst-gnu2-tls2-amx-mod1.c | 2 +
> .../linux/x86_64/tst-gnu2-tls2-amx-mod2.c | 2 +
> .../sysv/linux/x86_64/tst-gnu2-tls2-amx.c | 83 ++++++++
> .../sysv/linux/x86_64/tst-gnu2-tls2-amx.h | 63 ++++++
> sysdeps/x86/Makefile | 7 +-
> sysdeps/x86/cpu-features-offsets.sym | 1 +
> sysdeps/x86/cpu-features.c | 118 ++++++++++-
> sysdeps/x86/dl-procinfo.c | 16 ++
> sysdeps/{x86_64 => x86}/features-offsets.sym | 2 +
> sysdeps/x86/include/cpu-features.h | 2 +
> sysdeps/x86/sysdep.h | 78 ++++++-
> sysdeps/x86/tst-gnu2-tls2.c | 20 ++
> sysdeps/x86_64/Makefile | 4 +-
> sysdeps/x86_64/configure | 28 +++
> sysdeps/x86_64/configure.ac | 15 ++
> sysdeps/x86_64/dl-machine.h | 19 +-
> sysdeps/x86_64/dl-procinfo.c | 16 ++
> sysdeps/x86_64/dl-tlsdesc-dynamic.h | 166 +++++++++++++++
> sysdeps/x86_64/dl-tlsdesc.S | 108 +++-------
> sysdeps/x86_64/dl-trampoline-save.h | 34 ++++
> sysdeps/x86_64/dl-trampoline-state.h | 51 +++++
> sysdeps/x86_64/dl-trampoline.S | 20 +-
> sysdeps/x86_64/dl-trampoline.h | 34 +---
> sysdeps/x86_64/tst-gnu2-tls2mod1.S | 87 ++++++++
> 45 files changed, 1644 insertions(+), 264 deletions(-)
> create mode 100644 elf/tst-gnu2-tls2.c
> create mode 100644 elf/tst-gnu2-tls2.h
> create mode 100644 elf/tst-gnu2-tls2mod0.c
> create mode 100644 elf/tst-gnu2-tls2mod1.c
> create mode 100644 elf/tst-gnu2-tls2mod2.c
> create mode 100644 sysdeps/arm/tst-gnu2-tls2.h
> create mode 100644 sysdeps/i386/dl-tlsdesc-dynamic.h
> create mode 100644 sysdeps/unix/sysv/linux/x86_64/tst-gnu2-tls2-amx-mod0.c
> create mode 100644 sysdeps/unix/sysv/linux/x86_64/tst-gnu2-tls2-amx-mod1.c
> create mode 100644 sysdeps/unix/sysv/linux/x86_64/tst-gnu2-tls2-amx-mod2.c
> create mode 100644 sysdeps/unix/sysv/linux/x86_64/tst-gnu2-tls2-amx.c
> create mode 100644 sysdeps/unix/sysv/linux/x86_64/tst-gnu2-tls2-amx.h
> rename sysdeps/{x86_64 => x86}/features-offsets.sym (89%)
> create mode 100644 sysdeps/x86/tst-gnu2-tls2.c
> create mode 100644 sysdeps/x86_64/dl-tlsdesc-dynamic.h
> create mode 100644 sysdeps/x86_64/dl-trampoline-save.h
> create mode 100644 sysdeps/x86_64/dl-trampoline-state.h
> create mode 100644 sysdeps/x86_64/tst-gnu2-tls2mod1.S
>
> --
> 2.44.0
>
>
LGTM
--Sunil
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Backport: v2 0/7] Update _dl_tlsdesc_dynamic to preserve caller-saved registers
@ 2024-04-02 13:27 H.J. Lu
2024-04-03 22:32 ` Sunil Pandey
0 siblings, 1 reply; 3+ messages in thread
From: H.J. Lu @ 2024-04-02 13:27 UTC (permalink / raw)
To: libc-stable; +Cc: fweimer, adhemerval.zanella, carlos, goldstein.w.n, skpgkp2
Changes in v2:
1. Add tst-gnu2-tls2mod1 to test-internal-extras.
---
GNU2 TLS descriptor instruction sequences have implicit _dl_tlsdesc_dynamic
call and compilers assume that caller-saved registers are unchanged after
call. Update _dl_tlsdesc_dynamic to preserve caller-saved registers.
Adhemerval Zanella (3):
Ignore undefined symbols for -mtls-dialect=gnu2
arm: Update _dl_tlsdesc_dynamic to preserve caller-saved registers (BZ
31372)
elf: Enable TLS descriptor tests on aarch64
Andreas Schwab (1):
Add tst-gnu2-tls2mod1 to test-internal-extras
H.J. Lu (3):
x86: Update _dl_tlsdesc_dynamic to preserve caller-saved registers
x86-64: Update _dl_tlsdesc_dynamic to preserve AMX registers
x86-64: Allocate state buffer space for RDI, RSI and RBX
config.h.in | 3 +
configure | 25 ++-
configure.ac | 17 +-
elf/Makefile | 34 +++-
elf/tst-gnu2-tls2.c | 122 +++++++++++
elf/tst-gnu2-tls2.h | 40 ++++
elf/tst-gnu2-tls2mod0.c | 32 +++
elf/tst-gnu2-tls2mod1.c | 32 +++
elf/tst-gnu2-tls2mod2.c | 32 +++
sysdeps/aarch64/preconfigure | 1 +
sysdeps/arm/Makefile | 8 +-
sysdeps/arm/configure | 32 +++
sysdeps/arm/configure.ac | 15 ++
sysdeps/arm/dl-tlsdesc.S | 70 ++++++-
sysdeps/arm/tst-gnu2-tls2.h | 128 ++++++++++++
sysdeps/i386/dl-machine.h | 2 +-
sysdeps/i386/dl-tlsdesc-dynamic.h | 190 ++++++++++++++++++
sysdeps/i386/dl-tlsdesc.S | 115 +++++------
sysdeps/unix/sysv/linux/x86_64/Makefile | 27 +++
.../sysv/linux/x86_64/include/asm/prctl.h | 5 +
.../linux/x86_64/tst-gnu2-tls2-amx-mod0.c | 2 +
.../linux/x86_64/tst-gnu2-tls2-amx-mod1.c | 2 +
.../linux/x86_64/tst-gnu2-tls2-amx-mod2.c | 2 +
.../sysv/linux/x86_64/tst-gnu2-tls2-amx.c | 83 ++++++++
.../sysv/linux/x86_64/tst-gnu2-tls2-amx.h | 63 ++++++
sysdeps/x86/Makefile | 7 +-
sysdeps/x86/cpu-features-offsets.sym | 1 +
sysdeps/x86/cpu-features.c | 118 ++++++++++-
sysdeps/x86/dl-procinfo.c | 16 ++
sysdeps/{x86_64 => x86}/features-offsets.sym | 2 +
sysdeps/x86/include/cpu-features.h | 2 +
sysdeps/x86/sysdep.h | 78 ++++++-
sysdeps/x86/tst-gnu2-tls2.c | 20 ++
sysdeps/x86_64/Makefile | 4 +-
sysdeps/x86_64/configure | 28 +++
sysdeps/x86_64/configure.ac | 15 ++
sysdeps/x86_64/dl-machine.h | 19 +-
sysdeps/x86_64/dl-procinfo.c | 16 ++
sysdeps/x86_64/dl-tlsdesc-dynamic.h | 166 +++++++++++++++
sysdeps/x86_64/dl-tlsdesc.S | 108 +++-------
sysdeps/x86_64/dl-trampoline-save.h | 34 ++++
sysdeps/x86_64/dl-trampoline-state.h | 51 +++++
sysdeps/x86_64/dl-trampoline.S | 20 +-
sysdeps/x86_64/dl-trampoline.h | 34 +---
sysdeps/x86_64/tst-gnu2-tls2mod1.S | 87 ++++++++
45 files changed, 1644 insertions(+), 264 deletions(-)
create mode 100644 elf/tst-gnu2-tls2.c
create mode 100644 elf/tst-gnu2-tls2.h
create mode 100644 elf/tst-gnu2-tls2mod0.c
create mode 100644 elf/tst-gnu2-tls2mod1.c
create mode 100644 elf/tst-gnu2-tls2mod2.c
create mode 100644 sysdeps/arm/tst-gnu2-tls2.h
create mode 100644 sysdeps/i386/dl-tlsdesc-dynamic.h
create mode 100644 sysdeps/unix/sysv/linux/x86_64/tst-gnu2-tls2-amx-mod0.c
create mode 100644 sysdeps/unix/sysv/linux/x86_64/tst-gnu2-tls2-amx-mod1.c
create mode 100644 sysdeps/unix/sysv/linux/x86_64/tst-gnu2-tls2-amx-mod2.c
create mode 100644 sysdeps/unix/sysv/linux/x86_64/tst-gnu2-tls2-amx.c
create mode 100644 sysdeps/unix/sysv/linux/x86_64/tst-gnu2-tls2-amx.h
rename sysdeps/{x86_64 => x86}/features-offsets.sym (89%)
create mode 100644 sysdeps/x86/tst-gnu2-tls2.c
create mode 100644 sysdeps/x86_64/dl-tlsdesc-dynamic.h
create mode 100644 sysdeps/x86_64/dl-trampoline-save.h
create mode 100644 sysdeps/x86_64/dl-trampoline-state.h
create mode 100644 sysdeps/x86_64/tst-gnu2-tls2mod1.S
--
2.44.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-03 22:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-03 17:22 [Backport: v2 0/7] Update _dl_tlsdesc_dynamic to preserve caller-saved registers Arjun Shankar
-- strict thread matches above, loose matches on Subject: below --
2024-04-02 13:27 H.J. Lu
2024-04-03 22:32 ` Sunil Pandey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).