* Re: [PATCH v1] x86: Set .text section in memset-vec-unaligned-erms
[not found] ` <CAFUsyf+1n23T61OP=miV0N=x_XfaL7XD0HL5aLoi9=D5fvw1bg@mail.gmail.com>
@ 2022-05-04 6:01 ` Sunil Pandey
0 siblings, 0 replies; only message in thread
From: Sunil Pandey @ 2022-05-04 6:01 UTC (permalink / raw)
To: Noah Goldstein, Libc-stable Mailing List; +Cc: H.J. Lu, GNU C Library
On Sat, Feb 12, 2022 at 1:44 PM Noah Goldstein via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> On Sat, Feb 12, 2022 at 9:47 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Sat, Feb 12, 2022 at 2:25 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > >
> > > commit 3d9f171bfb5325bd5f427e9fc386453358c6e840
> > > Author: H.J. Lu <hjl.tools@gmail.com>
> > > Date: Mon Feb 7 05:55:15 2022 -0800
> > >
> > > x86-64: Optimize bzero
> > >
> > > Remove setting the .text section for the code. This commit
> > > adds that back.
> > > ---
> > > sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> > > index 7c94fcdae1..785fee1d57 100644
> > > --- a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> > > +++ b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> > > @@ -114,6 +114,7 @@
> > > # error SECTION is not defined!
> > > #endif
> > >
> > > + .section SECTION(.text), "ax", @progbits
> > > #if IS_IN (libc)
> > > # if defined SHARED
> > > ENTRY_CHK (WMEMSET_CHK_SYMBOL (__wmemset_chk, unaligned))
> > > --
> > > 2.25.1
> > >
> >
> > LGTM.
> >
> > Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
> >
> > Thanks.
> >
>
> Thanks pushed.
> > --
> > H.J.
I would like to backport this patch to release branches.
Any comments or objections?
--Sunil
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-05-04 6:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220212102529.1380928-1-goldstein.w.n@gmail.com>
[not found] ` <CAMe9rOq8mXuHvTLnpa_awhm5Cr_qDNg9YQNsis0RTQ7cgY3bKA@mail.gmail.com>
[not found] ` <CAFUsyf+1n23T61OP=miV0N=x_XfaL7XD0HL5aLoi9=D5fvw1bg@mail.gmail.com>
2022-05-04 6:01 ` [PATCH v1] x86: Set .text section in memset-vec-unaligned-erms Sunil Pandey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).