From: "H.J. Lu" <hjl.tools@gmail.com>
To: Sunil Pandey <skpgkp2@gmail.com>
Cc: Libc-stable Mailing List <libc-stable@sourceware.org>
Subject: Re: [Backport] testsuite: stdlib/isomac.c: add missing include
Date: Thu, 9 May 2024 14:46:48 -0700 [thread overview]
Message-ID: <CAMe9rOqJ3j07VthWRQN-xjj=DkLAOUrSDupeB5rnGucOCSB7vg@mail.gmail.com> (raw)
In-Reply-To: <CAMAf5_cJFm=77xaZWcfKK6TTdYwNj07Z4PAtjggY2zXt3AKt7w@mail.gmail.com>
On Thu, May 9, 2024 at 2:45 PM Sunil Pandey <skpgkp2@gmail.com> wrote:
>
> I would like to backport following commit to 2.29 and 2.28 branches. Any comments or objections?
>
> commit 11f382ee780649549428cb25af3a9f1d3465868d
> Author: Aurelien Jarno <aurelien@aurel32.net>
> Date: Tue Jan 8 21:10:28 2019 +0100
>
> testsuite: stdlib/isomac.c: add missing include
>
> When running the testsuite, building stdlib/isomac.c outputs the
> following warning:
>
> gcc -O -D_GNU_SOURCE -DIS_IN_build -include /home/aurel32/glibc-build/config.h isomac.c -o /home/aurel32/glibc-build/stdlib/isomac
> isomac.c: In function ?get_null_defines?:
> isomac.c:260:3: warning: implicit declaration of function ?close?; did you mean ?pclose?? [-Wimplicit-function-declaration]
> close (fd);
> ^~~~~
> pclose
>
> Fix that by adding the <unistd.h> include.
>
> Changelog:
> * stdlib/isomac.c: Include <unistd.h>.
LGTM.
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
Thanks.
--
H.J.
prev parent reply other threads:[~2024-05-09 21:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 21:45 Sunil Pandey
2024-05-09 21:46 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOqJ3j07VthWRQN-xjj=DkLAOUrSDupeB5rnGucOCSB7vg@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=libc-stable@sourceware.org \
--cc=skpgkp2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).