* [Backport] testsuite: stdlib/isomac.c: add missing include
@ 2024-05-09 21:45 Sunil Pandey
2024-05-09 21:46 ` H.J. Lu
0 siblings, 1 reply; 2+ messages in thread
From: Sunil Pandey @ 2024-05-09 21:45 UTC (permalink / raw)
To: Libc-stable Mailing List, Hongjiu Lu
[-- Attachment #1: Type: text/plain, Size: 862 bytes --]
I would like to backport following commit to 2.29 and 2.28 branches. Any
comments or objections?
commit 11f382ee780649549428cb25af3a9f1d3465868d
Author: Aurelien Jarno <aurelien@aurel32.net>
Date: Tue Jan 8 21:10:28 2019 +0100
testsuite: stdlib/isomac.c: add missing include
When running the testsuite, building stdlib/isomac.c outputs the
following warning:
gcc -O -D_GNU_SOURCE -DIS_IN_build -include
/home/aurel32/glibc-build/config.h isomac.c -o
/home/aurel32/glibc-build/stdlib/isomac
isomac.c: In function ?get_null_defines?:
isomac.c:260:3: warning: implicit declaration of function ?close?;
did you mean ?pclose?? [-Wimplicit-function-declaration]
close (fd);
^~~~~
pclose
Fix that by adding the <unistd.h> include.
Changelog:
* stdlib/isomac.c: Include <unistd.h>.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Backport] testsuite: stdlib/isomac.c: add missing include
2024-05-09 21:45 [Backport] testsuite: stdlib/isomac.c: add missing include Sunil Pandey
@ 2024-05-09 21:46 ` H.J. Lu
0 siblings, 0 replies; 2+ messages in thread
From: H.J. Lu @ 2024-05-09 21:46 UTC (permalink / raw)
To: Sunil Pandey; +Cc: Libc-stable Mailing List
On Thu, May 9, 2024 at 2:45 PM Sunil Pandey <skpgkp2@gmail.com> wrote:
>
> I would like to backport following commit to 2.29 and 2.28 branches. Any comments or objections?
>
> commit 11f382ee780649549428cb25af3a9f1d3465868d
> Author: Aurelien Jarno <aurelien@aurel32.net>
> Date: Tue Jan 8 21:10:28 2019 +0100
>
> testsuite: stdlib/isomac.c: add missing include
>
> When running the testsuite, building stdlib/isomac.c outputs the
> following warning:
>
> gcc -O -D_GNU_SOURCE -DIS_IN_build -include /home/aurel32/glibc-build/config.h isomac.c -o /home/aurel32/glibc-build/stdlib/isomac
> isomac.c: In function ?get_null_defines?:
> isomac.c:260:3: warning: implicit declaration of function ?close?; did you mean ?pclose?? [-Wimplicit-function-declaration]
> close (fd);
> ^~~~~
> pclose
>
> Fix that by adding the <unistd.h> include.
>
> Changelog:
> * stdlib/isomac.c: Include <unistd.h>.
LGTM.
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-09 21:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-09 21:45 [Backport] testsuite: stdlib/isomac.c: add missing include Sunil Pandey
2024-05-09 21:46 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).