From: Filipe Brandenburger <filbranden@google.com>
To: libffi-discuss@sourceware.org
Cc: Filipe Brandenburger <filbranden@google.com>
Subject: [PATCH] Fix dejagnu test support for --tool_opts
Date: Wed, 03 Feb 2016 21:39:00 -0000 [thread overview]
Message-ID: <1454535567-9589-1-git-send-email-filbranden@google.com> (raw)
Right now it concatenates it with the existing options and then appends
it to that list, fix it to simply append it as is, same as it is done
with the other variables.
Tested by running the following command which includes gcc options:
$ make check RUNTESTFLAGS="--tool_opts '-Werror'"
Without this patch, all the tests fail. With it, the test succeed.
Inspecting the logs shows that -Werror was indeed used when compiling
the test sources.
---
Also available as a GitHub PR:
https://github.com/atgreen/libffi/pull/205
Re-sending it to this mailing list, in case GitHub PRs are not the best way to
push this, and e-mail submissions are preferred.
Thanks!
Filipe
testsuite/lib/libffi.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testsuite/lib/libffi.exp b/testsuite/lib/libffi.exp
index 1b8b008fe297..0d74627207dc 100644
--- a/testsuite/lib/libffi.exp
+++ b/testsuite/lib/libffi.exp
@@ -182,7 +182,7 @@ proc libffi_target_compile { source dest type options } {
# TOOL_OPTIONS must come first, so that it doesn't override testcase
# specific options.
if [info exists TOOL_OPTIONS] {
- lappend options [concat "additional_flags=$TOOL_OPTIONS" $options];
+ lappend options "additional_flags=$TOOL_OPTIONS"
}
# search for ffi_mips.h in srcdir, too
--
2.7.0.rc3.207.g0ac5344
next reply other threads:[~2016-02-03 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 21:39 Filipe Brandenburger [this message]
2016-02-09 22:17 ` Filipe Brandenburger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454535567-9589-1-git-send-email-filbranden@google.com \
--to=filbranden@google.com \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).