From: Filipe Brandenburger <filbranden@google.com>
To: libffi-discuss@sourceware.org
Subject: Re: [PATCH] Fix dejagnu test support for --tool_opts
Date: Tue, 09 Feb 2016 22:17:00 -0000 [thread overview]
Message-ID: <CADU+-uAA4PnFO6A8ZJLVtmg7AUd3TeCDA6EZ_v-ibFThdc2KpA@mail.gmail.com> (raw)
In-Reply-To: <1454535567-9589-1-git-send-email-filbranden@google.com>
On Wed, Feb 3, 2016 at 1:39 PM, Filipe Brandenburger
<filbranden@google.com> wrote:
> Right now it concatenates it with the existing options and then appends
> it to that list, fix it to simply append it as is, same as it is done
> with the other variables.
>
> Tested by running the following command which includes gcc options:
> $ make check RUNTESTFLAGS="--tool_opts '-Werror'"
>
> Without this patch, all the tests fail. With it, the test succeed.
> Inspecting the logs shows that -Werror was indeed used when compiling
> the test sources.
> ---
> Also available as a GitHub PR:
> https://github.com/atgreen/libffi/pull/205
>
> Re-sending it to this mailing list, in case GitHub PRs are not the best way to
> push this, and e-mail submissions are preferred.
Ping?
prev parent reply other threads:[~2016-02-09 22:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 21:39 Filipe Brandenburger
2016-02-09 22:17 ` Filipe Brandenburger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADU+-uAA4PnFO6A8ZJLVtmg7AUd3TeCDA6EZ_v-ibFThdc2KpA@mail.gmail.com \
--to=filbranden@google.com \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).