From: Tom Tromey <tom@tromey.com>
To: Martin Bekchiev <Martin.Bektchiev@progress.com>
Cc: "libffi-discuss\@sourceware.org" <libffi-discuss@sourceware.org>
Subject: Re: Fix Q registers parameter passing on ARM64
Date: Thu, 29 Nov 2018 17:52:00 -0000 [thread overview]
Message-ID: <87bm6793fr.fsf@tromey.com> (raw)
In-Reply-To: <C388A2DD-E96E-408B-90DA-90FAEDA6D58B@progress.com> (Martin Bekchiev's message of "Thu, 29 Nov 2018 14:27:50 +0000")
>>>>> "Martin" == Martin Bekchiev <Martin.Bektchiev@progress.com> writes:
Martin> I opened a PR with a very small fix on ARM64 architecture about a month ago. Can someone with commit rights please review and merge it?
Martin> https://github.com/libffi/libffi/pull/457
You pinged me for review and I dropped it. Sorry about that. Emailing
here is the right thing to do.
I don't know anything about ARM64 and so I was reluctant to merge it.
Could you possibly add a new regression test? Also, I'm wondering if
you re-ran the existing test suite after your change.
Tom
prev parent reply other threads:[~2018-11-29 17:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 14:27 Martin Bekchiev
2018-11-29 17:52 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm6793fr.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Martin.Bektchiev@progress.com \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).