libffi.pc from libffi-3.1 after `make install` is broken, new release propably in order

libffi.pc from libffi-3.1 after `make install` is broken, new release propably in order

[Samuli Suominen]

I think 3.1.1 should be rolled to cover issues of:

1. https://sourceware.org/ml/libffi-discuss/2014/msg00059.html
2. https://sourceware.org/ml/libffi-discuss/2014/msg00058.html

3. This issue:

$ ./configure --prefix=/usr
$ make
$ make install
$ pkg-config --libs libffi
-L$(libdir)/../lib64 -lffi

Notice the (), it should be {}, so now every reverse dependency that tries
to link to libffi using info provided by --libs libffi, won't compile,
due to the
syntax error!

- Samuli

Re: libffi.pc from libffi-3.1 after `make install` is broken, new release propably in order

[Anthony Green]

Samuli Suominen <ssuominen@gentoo.org> writes:

> I think 3.1.1 should be rolled to cover issues of:

Thanks Samuli.  I agree, and I've prepared almost everything.  Could you
please submit a patch for the last issue below?

Thanks!

AG


>
> 1. https://sourceware.org/ml/libffi-discuss/2014/msg00059.html
> 2. https://sourceware.org/ml/libffi-discuss/2014/msg00058.html
>
> 3. This issue:
>
> $ ./configure --prefix=/usr
> $ make
> $ make install
> $ pkg-config --libs libffi
> -L$(libdir)/../lib64 -lffi
>
> Notice the (), it should be {}, so now every reverse dependency that tries
> to link to libffi using info provided by --libs libffi, won't compile,
> due to the
> syntax error!
>
> - Samuli

-- 
Anthony Green, Principal Solutions Architect     green@redhat.com
Red Hat, Inc.                                    +1.647.477.3809

Re: libffi.pc from libffi-3.1 after `make install` is broken, new release propably in order

[Samuli Suominen]

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]


On 31/05/14 15:55, Anthony Green wrote:
> Samuli Suominen <ssuominen@gentoo.org> writes:
>
>> I think 3.1.1 should be rolled to cover issues of:
> Thanks Samuli.  I agree, and I've prepared almost everything.  Could you
> please submit a patch for the last issue below?
>
> Thanks!

This patch seems to work here.   Be careful, I tried my best to look
that it doesn't have any
unexpected consequences.  As in, please test.

Thanks,
Samuli

>> 1. https://sourceware.org/ml/libffi-discuss/2014/msg00059.html
>> 2. https://sourceware.org/ml/libffi-discuss/2014/msg00058.html
>>
>> 3. This issue:
>>
>> $ ./configure --prefix=/usr
>> $ make
>> $ make install
>> $ pkg-config --libs libffi
>> -L$(libdir)/../lib64 -lffi
>>
>> Notice the (), it should be {}, so now every reverse dependency that tries
>> to link to libffi using info provided by --libs libffi, won't compile,
>> due to the
>> syntax error!
>>
>> - Samuli


[-- Attachment #2: configure.ac-libffi.pc.patch --]
[-- Type: text/x-patch, Size: 844 bytes --]

http://sourceware.org/ml/libffi-discuss/2014/msg00063.html

--- configure.ac
+++ configure.ac
@@ -590,11 +590,11 @@
 if test "x$GCC" = "xyes"; then
   if test -n "$with_cross_host" &&
      test x"$with_cross_host" != x"no"; then
-    toolexecdir='$(exec_prefix)/$(target_alias)'
-    toolexeclibdir='$(toolexecdir)/lib'
+    toolexecdir="${exec_prefix}"/'$(target_alias)'
+    toolexeclibdir="${toolexecdir}"/lib
   else
-    toolexecdir='$(libdir)/gcc-lib/$(target_alias)'
-    toolexeclibdir='$(libdir)'
+    toolexecdir="${libdir}"/gcc-lib/'$(target_alias)'
+    toolexeclibdir="${libdir}"
   fi
   multi_os_directory=`$CC $CFLAGS -print-multi-os-directory`
   case $multi_os_directory in
@@ -603,7 +603,7 @@
   esac
   AC_SUBST(toolexecdir)
 else
-  toolexeclibdir='$(libdir)'
+  toolexeclibdir="${libdir}"
 fi
 AC_SUBST(toolexeclibdir)
 

Re: libffi.pc from libffi-3.1 after `make install` is broken, new release propably in order

[Anthony Green]

Samuli Suominen <ssuominen@gentoo.org> writes:

> On 31/05/14 15:55, Anthony Green wrote:
>> Samuli Suominen <ssuominen@gentoo.org> writes:
>>
>>> I think 3.1.1 should be rolled to cover issues of:
>> Thanks Samuli.  I agree, and I've prepared almost everything.  Could you
>> please submit a patch for the last issue below?
>>
>> Thanks!
>
> This patch seems to work here.   Be careful, I tried my best to look
> that it doesn't have any
> unexpected consequences.  As in, please test.

I tested it a little and it seems to work here.  Committed.  Thanks!

AG