Re: [PATCH libffi 2/4] Use a documented way to pass $compiler_vendor to DejaGNU

[Jeff Law <law@redhat.com>]

On Fri, 2020-04-03 at 23:55 +0100, Maciej W. Rozycki via Gcc-patches wrote:
> Use Autoconf substitution in the template used for extra DejaGNU site 
> configuration, which is a documented supported way to pass information 
> from the `configure' script, rather than resorting to a hack with 
> extracting an undocumented internal setting from `config.log' to pass 
> the compiler vendor to DejaGNU.  No functional change (and no risk of 
> breakage with some Autoconf version anymore).
> 
> Use AM_SUBST_NOTMAKE with the new substitution so as not to place it in 
> Makefile.in files, where it is not needed, and set the Autmoake version 
> requirement accordingly.
> ---
> Hi,
> 
>  I chose to use AM_SUBST_NOTMAKE so as not to clutter Makefile.in files 
> with the new variable as Automake does that by default.  That however 
> requires the use of Automake 1.11 or newer.  By the look of our sources 
> that shouldn't be an issue as far as I can tell, but the macro invocation 
> can be dropped along with the requirement if it would.
> 
>   Maciej
> ---
>  Makefile.am              |    3 ++-
>  configure.ac             |    2 ++
>  testsuite/lib/libffi.exp |    4 ----
>  testsuite/local.exp.in   |    1 +
>  4 files changed, 5 insertions(+), 5 deletions(-)
OK
jeff
>