Re: [PATCH] libstdc++: ppc: conditionalize vsx-only simd intrinsics

[Segher Boessenkool <segher@kernel.crashing.org>]

Hi!

On Thu, Apr 28, 2022 at 10:53:40PM -0300, Alexandre Oliva wrote:
> On Apr 28, 2022, Segher Boessenkool <segher@kernel.crashing.org> wrote:
> > On Thu, Apr 28, 2022 at 03:09:54AM -0300, Alexandre Oliva wrote:
> >> +		  "no __intrinsic_type support for [long] double on PPC w/o VSX");
> > This change isn't in the changelog.
> 
> It is, it's just that long double is dealt with differently from the
> other types, so requiring VSX for it takes a different form:

It changes a diagnostic message.  Incorrectly, even.  The changelog does
not talk about this.

The only thing I use changelogs for nowadays is to help reviewing code.
So when things are missing it stands out like a sore thumb.

> > 	* include/experimental/bits/simd.h [__ALTIVEC__]: Require VSX
> > 	for double, long long, and 64-bit long and 64-bit long double
> > 	intrinsic types.                           ^^^^^^^^^^^^^^^^^^

Yes, that does not talk about changing a diagnostic message.

> > The message should not say "long
> > double" without qualifying it as "64-bit long double".
> 
> How about qualifying both such messages as in this incremental patchlet:

Send full patches always please.  Not patches relative to some
non-existing state :-)

Thanks,


Segher