public inbox for
 help / color / mirror / Atom feed
From: Alexandre Oliva <>
To: Segher Boessenkool <>
	David Edelsohn <>
Subject: Re: [PATCH] libstdc++: ppc: conditionalize vsx-only simd intrinsics
Date: Thu, 28 Apr 2022 22:53:40 -0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Segher Boessenkool's message of "Thu, 28 Apr 2022 08:03:06 -0500")

On Apr 28, 2022, Segher Boessenkool <> wrote:

> On Thu, Apr 28, 2022 at 03:09:54AM -0300, Alexandre Oliva wrote:

>> +# ifdef __VSX__

> No space after # (here and everywhere else).

'k, thanks

>> +		  "no __intrinsic_type support for [long] double on PPC w/o VSX");

> This change isn't in the changelog.

It is, it's just that long double is dealt with differently from the
other types, so requiring VSX for it takes a different form:

> 	* include/experimental/bits/simd.h [__ALTIVEC__]: Require VSX
> 	for double, long long, and 64-bit long and 64-bit long double
> 	intrinsic types.                           ^^^^^^^^^^^^^^^^^^

> The message should not say "long
> double" without qualifying it as "64-bit long double".

How about qualifying both such messages as in this incremental patchlet:

@@ -2456,11 +2456,11 @@ template <typename _Tp, size_t _Bytes>
     static constexpr bool _S_is_ldouble = is_same_v<_Tp, long double>;
     // allow _Tp == long double with -mlong-double-64
     static_assert(!(_S_is_ldouble && sizeof(long double) > sizeof(double)),
-		  "no __intrinsic_type support for long double on PPC");
+		  "no __intrinsic_type support for 128-bit floating point on PPC");
 #ifndef __VSX__
     static_assert(!(is_same_v<_Tp, double>
 		    || (_S_is_ldouble && sizeof(long double) == sizeof(double))),
-		  "no __intrinsic_type support for [long] double on PPC w/o VSX");
+		  "no __intrinsic_type support for 64-bit floating point on PPC w/o VSX");
     using type =
       typename __intrinsic_type_impl<

> Okay for trunk without this part of the patch, and the spaces after the
> hash signs deleted.  Or send a new patch with the "[long] double" thing
> fixed?

Thanks, awaiting feedback on the suggestion above to post the consolidated patch.

Alexandre Oliva, happy hacker      
   Free Software Activist                       GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <>

  reply	other threads:[~2022-04-29  1:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28  6:09 Alexandre Oliva
2022-04-28 13:03 ` Segher Boessenkool
2022-04-29  1:53   ` Alexandre Oliva [this message]
2022-04-29 18:44     ` Matthias Kretz
2022-05-02 21:36     ` Segher Boessenkool
2022-05-03  2:00       ` [PATCH v2] " Alexandre Oliva
2022-05-06 16:14         ` Segher Boessenkool
2022-05-06 17:05           ` Jonathan Wakely
2022-05-06 18:24             ` [PATCH v3] " Alexandre Oliva
2022-04-28 13:56 ` [PATCH] " Matthias Kretz
2022-04-28 16:06   ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).