From: Jonathan Wakely <jwakely@redhat.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: testsuite: skip fs space tests if not available
Date: Wed, 22 Jun 2022 10:46:20 +0100 [thread overview]
Message-ID: <CACb0b4=MDdiisR36Juo5we9iJDvLKz-yG_Yq4uhJAvuUz8_1ZA@mail.gmail.com> (raw)
In-Reply-To: <oredzh9prm.fsf@lxoliva.fsfla.org>
On Wed, 22 Jun 2022 at 07:28, Alexandre Oliva via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
>
> The do_space function is defined in ways that are useful, or that fail
> immediately, depending on various macros. When it fails immediately,
> the filesystem space.cc tests fail noisily, but the fail is entirely
> expected.
>
> Define HAVE_SPACE in the space.cc tests, according to the macros that
> select implementations of do_space, and use it to skip tests that are
> expected to fail.
>
> Regstrapped on x86_64-linux-gnu, also tested with a cross to
> aarch64-rtems6. Ok to install?
OK.
This could be done once in testsuite_fs.h as well.
next prev parent reply other threads:[~2022-06-22 9:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 6:27 Alexandre Oliva
2022-06-22 9:46 ` Jonathan Wakely [this message]
2022-06-23 11:06 ` Alexandre Oliva
2022-06-23 11:31 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4=MDdiisR36Juo5we9iJDvLKz-yG_Yq4uhJAvuUz8_1ZA@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=oliva@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).