public inbox for
 help / color / mirror / Atom feed
From: Jonathan Wakely <>
To: "François Dumont" <>
Cc: "libstdc++" <>,
	gcc-patches <>
Subject: Re: [PATCH][_GLIBCXX_INLINE_VERSION] Fix <contracts>
Date: Wed, 20 Sep 2023 10:32:05 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, 20 Sept 2023 at 05:51, François Dumont via Libstdc++
<> wrote:
> libstdc++: Remove std::constract_violation from versioned namespace

Spelling mistake in contract_violation, and it's not
std::contract_violation, it's std::experimental::contract_violation

> GCC expects this type to be in std namespace directly.

Again, it's in std::experimental not in std directly.

Will this change cause problems when including another experimental
header, which does put experimental below std::__8?

I think std::__8::experimental and std::experimental will become ambiguous.

Maybe we do want to remove the inline __8 namespace from all
experimental headers. That needs a bit more thought though.

> libstdc++-v3/ChangeLog:
>      * include/experimental/contract:

This line is too long for the changelog.

> It does fix 29 g++.dg/contracts in gcc testsuite.
> Ok to commit ?
> François

  reply	other threads:[~2023-09-20  9:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20  4:51 François Dumont
2023-09-20  9:32 ` Jonathan Wakely [this message]
2023-09-20 17:51   ` François Dumont
2023-09-21  4:41     ` François Dumont
2023-10-08 14:06       ` Iain Sandoe
2023-10-09  5:06         ` François Dumont
2023-10-09  9:23           ` Iain Sandoe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).