* [PATCH] libstdc++: Implement LWG 3555 changes to transform/elements_view
@ 2021-06-18 4:00 Patrick Palka
2021-06-18 21:55 ` Jonathan Wakely
0 siblings, 1 reply; 2+ messages in thread
From: Patrick Palka @ 2021-06-18 4:00 UTC (permalink / raw)
To: gcc-patches; +Cc: libstdc++, Patrick Palka
libstdc++-v3/ChangeLog:
* include/std/ranges (transform_view::_Iterator::_S_iter_concept):
Consider _Base instead of _Vp as per LWG 3555.
(elements_view::_Iterator::_S_iter_concept): Likewise.
---
libstdc++-v3/include/std/ranges | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/libstdc++-v3/include/std/ranges b/libstdc++-v3/include/std/ranges
index f93a880ff8a..bf85b1629f0 100644
--- a/libstdc++-v3/include/std/ranges
+++ b/libstdc++-v3/include/std/ranges
@@ -1613,11 +1613,11 @@ namespace views::__adaptor
static auto
_S_iter_concept()
{
- if constexpr (random_access_range<_Vp>)
+ if constexpr (random_access_range<_Base>)
return random_access_iterator_tag{};
- else if constexpr (bidirectional_range<_Vp>)
+ else if constexpr (bidirectional_range<_Base>)
return bidirectional_iterator_tag{};
- else if constexpr (forward_range<_Vp>)
+ else if constexpr (forward_range<_Base>)
return forward_iterator_tag{};
else
return input_iterator_tag{};
@@ -3659,11 +3659,11 @@ namespace views::__adaptor
static auto
_S_iter_concept()
{
- if constexpr (random_access_range<_Vp>)
+ if constexpr (random_access_range<_Base>)
return random_access_iterator_tag{};
- else if constexpr (bidirectional_range<_Vp>)
+ else if constexpr (bidirectional_range<_Base>)
return bidirectional_iterator_tag{};
- else if constexpr (forward_range<_Vp>)
+ else if constexpr (forward_range<_Base>)
return forward_iterator_tag{};
else
return input_iterator_tag{};
--
2.32.0.93.g670b81a890
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libstdc++: Implement LWG 3555 changes to transform/elements_view
2021-06-18 4:00 [PATCH] libstdc++: Implement LWG 3555 changes to transform/elements_view Patrick Palka
@ 2021-06-18 21:55 ` Jonathan Wakely
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Wakely @ 2021-06-18 21:55 UTC (permalink / raw)
To: Patrick Palka; +Cc: gcc Patches, libstdc++
On Fri, 18 Jun 2021 at 05:04, Patrick Palka via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
> libstdc++-v3/ChangeLog:
>
> * include/std/ranges (transform_view::_Iterator::_S_iter_concept):
> Consider _Base instead of _Vp as per LWG 3555.
> (elements_view::_Iterator::_S_iter_concept): Likewise.
OK
> ---
> libstdc++-v3/include/std/ranges | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/libstdc++-v3/include/std/ranges b/libstdc++-v3/include/std/ranges
> index f93a880ff8a..bf85b1629f0 100644
> --- a/libstdc++-v3/include/std/ranges
> +++ b/libstdc++-v3/include/std/ranges
> @@ -1613,11 +1613,11 @@ namespace views::__adaptor
> static auto
> _S_iter_concept()
> {
> - if constexpr (random_access_range<_Vp>)
> + if constexpr (random_access_range<_Base>)
> return random_access_iterator_tag{};
> - else if constexpr (bidirectional_range<_Vp>)
> + else if constexpr (bidirectional_range<_Base>)
> return bidirectional_iterator_tag{};
> - else if constexpr (forward_range<_Vp>)
> + else if constexpr (forward_range<_Base>)
> return forward_iterator_tag{};
> else
> return input_iterator_tag{};
> @@ -3659,11 +3659,11 @@ namespace views::__adaptor
> static auto
> _S_iter_concept()
> {
> - if constexpr (random_access_range<_Vp>)
> + if constexpr (random_access_range<_Base>)
> return random_access_iterator_tag{};
> - else if constexpr (bidirectional_range<_Vp>)
> + else if constexpr (bidirectional_range<_Base>)
> return bidirectional_iterator_tag{};
> - else if constexpr (forward_range<_Vp>)
> + else if constexpr (forward_range<_Base>)
> return forward_iterator_tag{};
> else
> return input_iterator_tag{};
> --
> 2.32.0.93.g670b81a890
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-18 21:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-18 4:00 [PATCH] libstdc++: Implement LWG 3555 changes to transform/elements_view Patrick Palka
2021-06-18 21:55 ` Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).