From: Jonathan Wakely <jwakely@redhat.com>
To: libstdc++@gcc.gnu.org
Subject: Re: Minor nit in tzdb.cc
Date: Thu, 26 Jan 2023 16:01:32 +0000 [thread overview]
Message-ID: <CACb0b4n1QP03zHPRaoMf37uHYsWJ9iZp5qwQKJ18MOrTcMctvw@mail.gmail.com> (raw)
In-Reply-To: <87v8kts3ol.fsf@md5i.com>
On Thu, 26 Jan 2023 at 15:45, Michael Welsh Duggan wrote:
>
> In tzdb.cc, the constant "/tzdata.zi" is used in the tzdata_stream
> constructor, but the tzdata_file constant probably was meant to be used
> instead (currently unused).
Ah yes, good catch. I initially put the tzdata_stream in a separate
file, where the constant wasn't visible. When I moved it back into
tzdb.cc I forgot to reconcile that.
> Should I have created a bugzilla issue rather than sending this here?
> It's not really a bug, per se. It feels more like a style question.
Raising it like this is fine, I will push the fix shortly. Thanks for
spotting it!
prev parent reply other threads:[~2023-01-26 16:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 15:42 Michael Welsh Duggan
2023-01-26 16:01 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4n1QP03zHPRaoMf37uHYsWJ9iZp5qwQKJ18MOrTcMctvw@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).