From: Jonathan Wakely <jwakely@redhat.com>
To: Thomas Rodgers <rodgert@appliantology.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org,
Thomas Rodgers <trodgers@redhat.com>
Subject: Re: [PATCH] libstdc++: Fix Wrong param type in :atomic_ref<_Tp*>::wait [PR100889]
Date: Tue, 8 Jun 2021 16:44:12 +0100 [thread overview]
Message-ID: <CACb0b4ns8i57KqainYzLvPjWfDQLgjehOu5o-C2QKqjfhWPN1g@mail.gmail.com> (raw)
In-Reply-To: <20210608002843.945023-1-rodgert@appliantology.com>
On Tue, 8 Jun 2021 at 01:29, Thomas Rodgers wrote:
> This time without the repeatred [PRnnnn] in the subject line.
>
> Fixes libstdc++/100889
>
This should be part of the ChangeLog entry instead, preceded by PR so it
updates bugzilla, i.e.
> libstdc++-v3/ChangeLog:
>
<TAB>PR libstdc++/100889
> * include/bits/atomic_base.h (atomic_ref<_Tp*>::wait):
> Change parameter type from _Tp to _Tp*.
> * testsuite/29_atomics/atomic_ref/wait_notify.cc: Extend
> coverage of types tested.
>
OK for trunk and gcc-11 with that change, thanks.
next prev parent reply other threads:[~2021-06-08 15:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 23:04 [PATCH] PR libstdc++/100889: Fix wrong param type in atomic_ref<_Tp*>::wait Thomas Rodgers
2021-06-04 23:18 ` Jonathan Wakely
2021-06-05 0:44 ` [PATCH] [libstdc++] Fix Wrong param type in :atomic_ref<_Tp*>::wait [PR100889] Thomas Rodgers
2021-06-07 22:02 ` [PATCH] libstdc++: Fix Wrong param type in :atomic_ref<_Tp*>::wait [PR100889] [PR100889] Thomas Rodgers
2021-06-08 0:28 ` [PATCH] libstdc++: Fix Wrong param type in :atomic_ref<_Tp*>::wait [PR100889] Thomas Rodgers
2021-06-08 15:44 ` Jonathan Wakely [this message]
2021-06-08 23:03 ` Thomas Rodgers
2021-06-09 14:30 ` Christophe Lyon
2021-06-09 14:52 ` Thomas Rodgers
2021-06-09 15:11 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4ns8i57KqainYzLvPjWfDQLgjehOu5o-C2QKqjfhWPN1g@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=rodgert@appliantology.com \
--cc=trodgers@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).