From: Thomas Rodgers <trodgers@redhat.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: Iain Sandoe <iain@sandoe.co.uk>,
libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [RFA] choosing __platform_wait_t on targets without lock-free 64 atomics
Date: Wed, 11 Jan 2023 17:27:26 -0800 [thread overview]
Message-ID: <CAMmuTO8G4s5mM2fHu4NfSJhVtyg0WrOiHu-cdMNtSq9BYu7_Rw@mail.gmail.com> (raw)
In-Reply-To: <20230106002239.102638-1-jwakely@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1670 bytes --]
I agree with this change.
On Thu, Jan 5, 2023 at 4:22 PM Jonathan Wakely <jwakely@redhat.com> wrote:
> How about this?
>
> I don't think we should worry about targets without atomic int, so don't
> bother using types smaller than int.
>
>
> -- >8 --
>
> For non-futex targets the __platform_wait_t type is currently uint64_t,
> but that requires a lock in libatomic for some 32-bit targets. We don't
> really need a 64-bit type, so use unsigned long if that is lock-free,
> and int otherwise. This should mean it's lock-free on a wider set of
> targets.
>
> libstdc++-v3/ChangeLog:
>
> * include/bits/atomic_wait.h (__detail::__platform_wait_t):
> Define as unsigned long if always lock-free, and unsigned int
> otherwise.
> ---
> libstdc++-v3/include/bits/atomic_wait.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/libstdc++-v3/include/bits/atomic_wait.h
> b/libstdc++-v3/include/bits/atomic_wait.h
> index bd1ed56d157..46f39f10cbc 100644
> --- a/libstdc++-v3/include/bits/atomic_wait.h
> +++ b/libstdc++-v3/include/bits/atomic_wait.h
> @@ -64,7 +64,11 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
> // and __platform_notify() if there is a more efficient primitive
> supported
> // by the platform (e.g. __ulock_wait()/__ulock_wake()) which is better
> than
> // a mutex/condvar based wait.
> - using __platform_wait_t = uint64_t;
> +# if ATOMIC_LONG_LOCK_FREE == 2
> + using __platform_wait_t = unsigned long;
> +# else
> + using __platform_wait_t = unsigned int;
> +# endif
> inline constexpr size_t __platform_wait_alignment
> = __alignof__(__platform_wait_t);
> #endif
> --
> 2.39.0
>
>
next prev parent reply other threads:[~2023-01-12 1:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 11:28 Iain Sandoe
2022-12-29 12:09 ` Jonathan Wakely
2022-12-29 15:30 ` Iain Sandoe
2022-12-29 15:44 ` Jonathan Wakely
2022-12-29 15:56 ` Iain Sandoe
2022-12-29 17:02 ` Jonathan Wakely
2022-12-30 10:51 ` Iain Sandoe
2023-01-02 0:53 ` Thomas Rodgers
2023-01-02 7:47 ` Iain Sandoe
2023-01-03 1:13 ` Thomas Rodgers
2023-01-06 0:22 ` Jonathan Wakely
2023-01-12 1:27 ` Thomas Rodgers [this message]
2023-01-12 11:01 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMmuTO8G4s5mM2fHu4NfSJhVtyg0WrOiHu-cdMNtSq9BYu7_Rw@mail.gmail.com \
--to=trodgers@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).