From: Jakub Jelinek <jakub@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Jonathan Wakely <jwakely@redhat.com>,
Patrick Palka <ppalka@redhat.com>,
libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: Add _Float128 to_chars/from_chars support for x86, ia64 and ppc64le with glibc
Date: Tue, 8 Nov 2022 09:43:14 +0100 [thread overview]
Message-ID: <Y2oWotUFn6VAofsI@tucnak> (raw)
In-Reply-To: <eede82c7-1611-9718-6161-a2a738bf91db@codesourcery.com>
On Tue, Nov 08, 2022 at 01:41:41AM +0000, Joseph Myers wrote:
> I've committed this further fix for a syntax error as obvious.
Thanks and sorry.
> libstdc++: Fix syntax error in old-glibc case in floating_from_chars.cc [PR107562]
>
> PR libstdc++/107562
> * src/c++17/floating_from_chars.cc (from_chars_impl): Fix syntax
> error.
>
> diff --git a/libstdc++-v3/src/c++17/floating_from_chars.cc b/libstdc++-v3/src/c++17/floating_from_chars.cc
> index 29eb4634e9d..be1e1051b5c 100644
> --- a/libstdc++-v3/src/c++17/floating_from_chars.cc
> +++ b/libstdc++-v3/src/c++17/floating_from_chars.cc
> @@ -632,7 +632,7 @@ namespace
> {
> #ifndef _GLIBCXX_HAVE_FLOAT128_MATH
> if (&__strtof128 == nullptr)
> - tmpval = _Float128(std::strtold(str, &endptr);
> + tmpval = _Float128(std::strtold(str, &endptr));
> else
> #endif
> tmpval = __strtof128(str, &endptr);
Jakub
prev parent reply other threads:[~2022-11-08 8:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 9:25 Jakub Jelinek
2022-11-07 13:45 ` Jonathan Wakely
2022-11-07 16:11 ` Joseph Myers
2022-11-07 17:48 ` Jonathan Wakely
2022-11-07 17:52 ` Joseph Myers
2022-11-07 19:13 ` Jakub Jelinek
2022-11-07 22:43 ` Jonathan Wakely
2022-11-08 1:41 ` Joseph Myers
2022-11-08 8:43 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2oWotUFn6VAofsI@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).