From: Joseph Myers <joseph@codesourcery.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
Patrick Palka <ppalka@redhat.com>, <libstdc++@gcc.gnu.org>,
<gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Add _Float128 to_chars/from_chars support for x86, ia64 and ppc64le with glibc
Date: Mon, 7 Nov 2022 17:52:13 +0000 [thread overview]
Message-ID: <ec68e61c-da7e-cabc-ded0-14bc42d485e1@codesourcery.com> (raw)
In-Reply-To: <CACb0b4nU=KV8kn12CGtfumATLfSnpJGg+vhLj4mAcZqw4=o07w@mail.gmail.com>
On Mon, 7 Nov 2022, Jonathan Wakely wrote:
> This seems to "fix" it (not sure if it's right though):
>
> #ifndef _GLIBCXX_HAVE_FLOAT128_MATH
> extern "C" _Float128 __strtof128(const char*, char**)
> __attribute__((__weak__));
> #endif
> extern "C" _Float128 __strtof128(const char*, char**)
> __asm ("strtof128");
Probably putting the __asm before the __attribute__ would also work
without needing a separate declaration (but might be less convenient for
the #if conditionals).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2022-11-07 17:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 9:25 Jakub Jelinek
2022-11-07 13:45 ` Jonathan Wakely
2022-11-07 16:11 ` Joseph Myers
2022-11-07 17:48 ` Jonathan Wakely
2022-11-07 17:52 ` Joseph Myers [this message]
2022-11-07 19:13 ` Jakub Jelinek
2022-11-07 22:43 ` Jonathan Wakely
2022-11-08 1:41 ` Joseph Myers
2022-11-08 8:43 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec68e61c-da7e-cabc-ded0-14bc42d485e1@codesourcery.com \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).