Re: [PATCH] Hashtable PR96088

["François Dumont" <frs.dumont@gmail.com>]

On 01/06/21 8:10 pm, Jonathan Wakely wrote:
> On 01/06/21 18:47 +0100, Jonathan Wakely wrote:
>> On 01/06/21 18:45 +0100, Jonathan Wakely wrote:
>>> On 22/05/21 18:35 +0200, François Dumont wrote:
>>>> diff --git 
>>>> a/libstdc++-v3/testsuite/23_containers/unordered_set/96088.cc 
>>>> b/libstdc++-v3/testsuite/23_containers/unordered_set/96088.cc
>>>> new file mode 100644
>>>> index 00000000000..53bb754dab6
>>>> --- /dev/null
>>>> +++ b/libstdc++-v3/testsuite/23_containers/unordered_set/96088.cc
>>>> @@ -0,0 +1,271 @@
>>>> +// { dg-do run { target c++11 } }
>>>> +
>>>> +// Copyright (C) 2021 Free Software Foundation, Inc.
>>>> +//
>>>> +// This file is part of the GNU ISO C++ Library.  This library is 
>>>> free
>>>> +// software; you can redistribute it and/or modify it under the
>>>> +// terms of the GNU General Public License as published by the
>>>> +// Free Software Foundation; either version 3, or (at your option)
>>>> +// any later version.
>>>> +
>>>> +// This library is distributed in the hope that it will be useful,
>>>> +// but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>> +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>>>> +// GNU General Public License for more details.
>>>> +
>>>> +// You should have received a copy of the GNU General Public 
>>>> License along
>>>> +// with this library; see the file COPYING3.  If not see
>>>> +// <http://www.gnu.org/licenses/>.
>>>> +
>>>> +// libstdc++/96088
>>>> +
>>>> +#include <string_view>
>>>
>>> This is a c++11 test, but it uses <string_view>.
>>>
>>> The test fails for make check 
>>> RUNTESTFLAGS=--target_board=unix/-std=gnu++11
>>>
>>> I assume it should use { target c++17 } instead?
>>
>> Same for 23_containers/unordered_map/96088.cc
>
> I've pushed this fix.
>
> Tested x86_64-linux.
>
>
I wonder why the same in unordered_multimap/unordered_multiset are not 
wrong too.

Thanks