public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/lvchange.c Date: Mon, 10 Jul 2006 19:39:00 -0000 [thread overview] Message-ID: <20060710193915.23118.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2006-07-10 19:39:14 Modified files: . : WHATS_NEW tools : lvchange.c Log message: Fix activation logic in lvchange --persistent. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.408&r2=1.409 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvchange.c.diff?cvsroot=lvm2&r1=1.67&r2=1.68 --- LVM2/WHATS_NEW 2006/07/10 19:17:40 1.408 +++ LVM2/WHATS_NEW 2006/07/10 19:39:14 1.409 @@ -1,5 +1,6 @@ Version 2.02.07 - ================================= + Fix activation logic in lvchange --persistent. Don't ignore persistent minor numbers when activating. Use RTLD_GLOBAL when loading shared libraries. Add some forgotten memlock checks to _vg_read to protect against full scans. --- LVM2/tools/lvchange.c 2006/05/12 19:16:48 1.67 +++ LVM2/tools/lvchange.c 2006/07/10 19:39:14 1.68 @@ -315,14 +315,7 @@ lv->major = arg_int_value(cmd, major_ARG, lv->major); log_verbose("Setting persistent device number to (%d, %d) " "for \"%s\"", lv->major, lv->minor, lv->name); - if (active) { - log_verbose("Re-activating logical volume \"%s\"", - lv->name); - if (!activate_lv(cmd, lv)) { - log_error("%s: reactivation failed", lv->name); - return 0; - } - } + } log_very_verbose("Updating logical volume \"%s\" on disk(s)", lv->name); @@ -333,21 +326,17 @@ backup(lv->vg); - if (!suspend_lv(cmd, lv)) { - log_error("Failed to lock %s", lv->name); - vg_revert(lv->vg); - return 0; - } - if (!vg_commit(lv->vg)) { - resume_lv(cmd, lv); + stack; return 0; } - log_very_verbose("Updating permissions for \"%s\" in kernel", lv->name); - if (!resume_lv(cmd, lv)) { - log_error("Problem reactivating %s", lv->name); - return 0; + if (active) { + log_verbose("Re-activating logical volume \"%s\"", lv->name); + if (!activate_lv(cmd, lv)) { + log_error("%s: reactivation failed", lv->name); + return 0; + } } return 1;
next reply other threads:[~2006-07-10 19:39 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2006-07-10 19:39 agk [this message] 2006-10-13 21:33 agk 2008-01-26 0:13 agk 2008-05-21 14:10 agk 2008-07-31 13:03 agk 2009-06-06 22:00 mbroz 2009-08-13 14:27 mornfall 2011-09-05 12:54 agk 2011-11-18 19:22 zkabelac
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20060710193915.23118.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).